Misc Fixes 1 (#2382)

- Fix color issue for mobile menu icon;
- Fixed Chrome 73 overflow issue in main folder view;
- Better fixes for Chrome 73 overflow bug;
- Code cleanup;

src/styles-new/_mixins.scss

@@ -425,12 +425,13 @@
     // Background is displayed on hover
     // Padding is included to facilitate a bigger hit area
     // Make the icon bigger relative to its container
+    $pLR: 4px;
+    $pTB: 4px;
+
     @include cControl();
     background: none;
     box-shadow: none;
     cursor: pointer;
-    $pLR: 4px;
-    $pTB: 4px;
     transition: $transOut;
     border-radius: $controlCr;
     padding: $pTB $pLR;

src/ui/layout/Layout.vue

@@ -75,6 +75,7 @@
                 // For mobile, collapse button becomes menu icon
                 body.mobile & {
                     @include cClickIconButton();
+                    color: $colorKey !important;
                     position: absolute;
                     right: -2 * nth($shellPanePad, 2); // Needs to be -1 * when pane is collapsed
                     top: 0;
@@ -186,6 +187,7 @@
         &__main-container {
             // Wrapper for main views
             flex: 1 1 auto !important;
+            height: 0; // Chrome 73 overflow bug fix
             overflow: auto;
         }
 

src/ui/layout/mct-tree.vue

@@ -52,13 +52,12 @@
 
         &__tree {
             flex: 1 1 auto;
-            height: 100%;
+            height: 0; // Chrome 73 overflow bug fix
         }
     }
 
     .c-tree {
         @include userSelectNone();
-        height: 100%; // Chrome 73 overflow bug fix
         overflow-x: hidden;
         overflow-y: auto;
         padding-right: $interiorMargin;