Fix stackplots static style (#5045)

* [4864] Fixes cancelling edit properties console error
* Get the style receiver when the styleRuleManager is initialized. This prevents any ambiguity about which element should receive the style

* Don't subscribe if the styleRuleManager has been destroyed

Co-authored-by: John Hill <john.c.hill@nasa.gov>
Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov>
Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov>
Co-authored-by: Andrew Henry <andrew.k.henry@nasa.gov>

src/plugins/condition/StyleRuleManager.js

@@ -78,11 +78,13 @@ export default class StyleRuleManager extends EventEmitter {
         this.openmct.objects.get(this.conditionSetIdentifier).then((conditionSetDomainObject) => {
             this.openmct.telemetry.request(conditionSetDomainObject)
                 .then(output => {
-                    if (output && output.length) {
+                    if (output && output.length && (this.conditionSetIdentifier && this.openmct.objects.areIdsEqual(conditionSetDomainObject.identifier, this.conditionSetIdentifier))) {
                         this.handleConditionSetResultUpdated(output[0]);
                     }
                 });
-            this.stopProvidingTelemetry = this.openmct.telemetry.subscribe(conditionSetDomainObject, this.handleConditionSetResultUpdated.bind(this));
+            if (this.conditionSetIdentifier && this.openmct.objects.areIdsEqual(conditionSetDomainObject.identifier, this.conditionSetIdentifier)) {
+                this.stopProvidingTelemetry = this.openmct.telemetry.subscribe(conditionSetDomainObject, this.handleConditionSetResultUpdated.bind(this));
+            }
         });
     }
 

src/plugins/formActions/EditPropertiesAction.js

@@ -76,6 +76,13 @@ export default class EditPropertiesAction extends PropertiesAction {
         }
     }
 
+    /**
+     * @private
+     */
+    _onCancel() {
+        //noop
+    }
+
     /**
      * @private
      */
@@ -87,6 +94,7 @@ export default class EditPropertiesAction extends PropertiesAction {
         formStructure.title = 'Edit ' + this.domainObject.name;
 
         return this.openmct.forms.showForm(formStructure)
-            .then(this._onSave.bind(this));
+            .then(this._onSave.bind(this))
+            .catch(this._onCancel.bind(this));
     }
 }

src/plugins/formActions/pluginSpec.js

@@ -123,6 +123,9 @@ describe('EditPropertiesAction plugin', () => {
         }
 
         editPropertiesAction.invoke([domainObject])
+            .then(() => {
+                done();
+            })
             .catch(() => {
                 done();
             });
@@ -208,6 +211,10 @@ describe('EditPropertiesAction plugin', () => {
         };
 
         editPropertiesAction.invoke([domainObject])
+            .then(() => {
+                expect(domainObject.name).toEqual(name);
+                done();
+            })
             .catch(() => {
                 expect(domainObject.name).toEqual(name);