diff --git a/src/plugins/events/components/EventTimelineView.vue b/src/plugins/events/components/EventTimelineView.vue index ce330d85d7..c0cef69b4e 100644 --- a/src/plugins/events/components/EventTimelineView.vue +++ b/src/plugins/events/components/EventTimelineView.vue @@ -53,19 +53,8 @@ export default { return { alignmentData }; }, data() { - const timeSystem = this.openmct.time.getTimeSystem(); - this.valueMetadata = {}; - this.requestCount = 0; - return { - viewBounds: null, - height: 0, - eventHistory: [], - timeSystem: timeSystem, - extendLines: false, - titleKey: null, - tooltip: null, - selectedEvent: null + eventHistory: [] }; }, computed: { @@ -82,24 +71,26 @@ export default { }, watch: { eventHistory: { - handler(newHistory, oldHistory) { + handler() { this.updatePlotEvents(); }, deep: true }, alignmentData: { handler() { - this.updateViewBounds(); + this.setScaleAndPlotEvents(this.timeSystem); }, deep: true } }, + created() { + this.valueMetadata = {}; + this.height = 0; + this.timeSystem = this.openmct.time.getTimeSystem(); + this.extendLines = false; + }, mounted() { this.setDimensions(); - - this.setScaleAndPlotEvents = this.setScaleAndPlotEvents.bind(this); - this.updateViewBounds = this.updateViewBounds.bind(this); - this.setTimeContext = this.setTimeContext.bind(this); this.setTimeContext(); this.limitEvaluator = this.openmct.telemetry.limitEvaluator(this.domainObject); @@ -175,7 +166,7 @@ export default { const clientWidth = this.getClientWidth(); if (clientWidth !== this.width) { this.setDimensions(); - this.updateViewBounds(); + this.setScaleAndPlotEvents(this.timeSystem); } }, getClientWidth() { @@ -446,20 +437,13 @@ export default { return eventWrapper; }, emitExtendedLines() { + let lines = []; if (this.extendLines) { - const lines = this.eventHistory + lines = this.eventHistory .filter((e) => this.isEventInBounds(e)) .map((e) => ({ x: this.xScale(e.time), limitClass: e.limitClass, id: e.time })); - this.extendedLinesBus.emit('update-extended-lines', { - lines, - keyString: this.keyString - }); - } else { - this.extendedLinesBus.emit('update-extended-lines', { - lines: [], - keyString: this.keyString - }); } + this.extendedLinesBus.updateExtendedLines(this.keyString, lines); }, showToolTip(textToShow, referenceElement, event) { const aClasses = ['c-events-tooltip']; diff --git a/src/plugins/timeline/ExtendedLinesBus.js b/src/plugins/timeline/ExtendedLinesBus.js index 56f7071985..a575050913 100644 --- a/src/plugins/timeline/ExtendedLinesBus.js +++ b/src/plugins/timeline/ExtendedLinesBus.js @@ -22,8 +22,8 @@ import { EventEmitter } from 'eventemitter3'; export default class ExtendedLinesBus extends EventEmitter { - updateExtendedLines(keyString, lineData) { - this.emit('update-extended-lines', { lineData, keyString }); + updateExtendedLines(keyString, lines) { + this.emit('update-extended-lines', { lines, keyString }); } disableExtendEventLines(keyString) { this.emit('disable-extended-lines', keyString); diff --git a/src/plugins/timeline/ExtendedLinesOverlay.vue b/src/plugins/timeline/ExtendedLinesOverlay.vue index 8492c509cd..27daa8219e 100644 --- a/src/plugins/timeline/ExtendedLinesOverlay.vue +++ b/src/plugins/timeline/ExtendedLinesOverlay.vue @@ -29,7 +29,7 @@