[Testing] Resolve all promises (#3829)

* all promises in test specs should be returned

Co-authored-by: Shefali Joshi <simplyrender@gmail.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
This commit is contained in:
David Tsay
2021-06-18 16:06:15 -07:00
committed by GitHub
parent 9d8a8b36d2
commit 333e8b5583
16 changed files with 227 additions and 164 deletions

View File

@ -112,7 +112,7 @@ let openmct;
let mockIdentifierService;
describe('Notebook Entries:', () => {
beforeEach(done => {
beforeEach(() => {
openmct = createOpenMct();
openmct.$injector = jasmine.createSpyObj('$injector', ['get']);
mockIdentifierService = jasmine.createSpyObj(
@ -134,8 +134,6 @@ describe('Notebook Entries:', () => {
'update'
]));
window.localStorage.setItem('notebook-storage', null);
done();
});
afterEach(() => {
@ -150,12 +148,11 @@ describe('Notebook Entries:', () => {
expect(entries.length).toEqual(0);
});
it('addNotebookEntry adds entry', (done) => {
it('addNotebookEntry adds entry', () => {
const unlisten = openmct.objects.observe(notebookDomainObject, '*', (object) => {
const entries = NotebookEntries.getNotebookEntries(notebookDomainObject, selectedSection, selectedPage);
expect(entries.length).toEqual(1);
done();
unlisten();
});

View File

@ -60,7 +60,7 @@ let openmct;
let mockIdentifierService;
describe('Notebook Storage:', () => {
beforeEach((done) => {
beforeEach(() => {
openmct = createOpenMct();
openmct.$injector = jasmine.createSpyObj('$injector', ['get']);
mockIdentifierService = jasmine.createSpyObj(
@ -79,7 +79,6 @@ describe('Notebook Storage:', () => {
'create',
'update'
]));
done();
});
afterEach(() => {