ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-02-21 01:42:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disallow pan, zoom and pause/play controls in time strip view (#3936)

Browse Source 
* Disallow pan and zoom when in time strip view

* Disable plot controls in time strip view
This commit is contained in:
Shefali Joshi 2021-06-22 09:25:12 -07:00 committed by GitHub
parent c946609d13
commit 300b98bd54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/plugins/plot/MctPlot.vue
View File

@ -74,7 +74,9 @@
</div>
<div class="gl-plot__local-controls h-local-controls h-local-controls--overlay-content c-local-controls--show-on-hover">
<div class="c-button-set c-button-set--strip-h">
<div v-if="!options.compact"
class="c-button-set c-button-set--strip-h js-zoom"
>
<button class="c-button icon-minus"
title="Zoom out"
@click="zoom('out', 0.2)"
@ -86,8 +88,8 @@
>
</button>
</div>
<div v-if="plotHistory.length"
class="c-button-set c-button-set--strip-h"
<div v-if="plotHistory.length && !options.compact"
class="c-button-set c-button-set--strip-h js-pan"
>
<button class="c-button icon-arrow-left"
title="Restore previous pan/zoom"
@ -101,7 +103,7 @@
</button>
</div>
<div v-if="isRealTime"
class="c-button-set c-button-set--strip-h"
class="c-button-set c-button-set--strip-h js-pause"
>
<button v-if="!isFrozen"
class="c-button icon-pause"
@ -493,10 +495,12 @@ export default {
this.canvas = this.$refs.chartContainer.querySelectorAll('canvas')[1];
this.listenTo(this.canvas, 'mousemove', this.trackMousePosition, this);
this.listenTo(this.canvas, 'mouseleave', this.untrackMousePosition, this);
this.listenTo(this.canvas, 'mousedown', this.onMouseDown, this);
this.listenTo(this.canvas, 'wheel', this.wheelZoom, this);
if (!this.options.compact) {
this.listenTo(this.canvas, 'mousemove', this.trackMousePosition, this);
this.listenTo(this.canvas, 'mouseleave', this.untrackMousePosition, this);
this.listenTo(this.canvas, 'mousedown', this.onMouseDown, this);
this.listenTo(this.canvas, 'wheel', this.wheelZoom, this);
}
},
initialize() {
@ -514,12 +518,7 @@ export default {
this.chartElementBounds = undefined;
this.tickUpdate = false;
this.canvas = this.$refs.chartContainer.querySelectorAll('canvas')[1];
this.listenTo(this.canvas, 'mousemove', this.trackMousePosition, this);
this.listenTo(this.canvas, 'mouseleave', this.untrackMousePosition, this);
this.listenTo(this.canvas, 'mousedown', this.onMouseDown, this);
this.listenTo(this.canvas, 'wheel', this.wheelZoom, this);
this.initCanvas();
this.config.yAxisLabel = this.config.yAxis.get('label');

19
src/plugins/plot/pluginSpec.js
View File

@ -403,6 +403,25 @@ describe("the plugin", function () {
});
});
describe('controls in time strip view', () => {
it('zoom controls are hidden', () => {
let pauseEl = element.querySelectorAll(".c-button-set .js-zoom");
expect(pauseEl.length).toBe(0);
});
it('pan controls are hidden', () => {
let pauseEl = element.querySelectorAll(".c-button-set .js-pan");
expect(pauseEl.length).toBe(0);
});
it('pause/play controls are hidden', () => {
let pauseEl = element.querySelectorAll(".c-button-set .js-pause");
expect(pauseEl.length).toBe(0);
});
});
});
describe("The stacked plot view", () => {