From 2f0ea1975057b5a5c9069fa7a72e60c3129fad80 Mon Sep 17 00:00:00 2001
From: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed, 5 Nov 2014 13:42:51 -0800
Subject: [PATCH] [Framework] Add clarifying comments
Add clarifying comments to code responsible for registering
empty extension categories, WTD-518.
---
platform/framework/src/register/ExtensionRegistrar.js | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/platform/framework/src/register/ExtensionRegistrar.js b/platform/framework/src/register/ExtensionRegistrar.js
index 10df1372c5..6d09a4a3a7 100644
--- a/platform/framework/src/register/ExtensionRegistrar.js
+++ b/platform/framework/src/register/ExtensionRegistrar.js
@@ -111,6 +111,8 @@ define(
return index !== -1;
}
+ // Examine a group of resolved dependencies to determine
+ // which extension categories still need to be satisfied.
function findEmptyExtensionDependencies(extensionGroup) {
var needed = {},
categories = Object.keys(extensionGroup),
@@ -141,6 +143,9 @@ define(
}
+ // Register any extension categories that are depended-upon but
+ // have not been declared anywhere; such dependencies are then
+ // satisfied by an empty array, instead of not at all.
function registerEmptyDependencies(extensionGroup) {
findEmptyExtensionDependencies(
extensionGroup
@@ -151,6 +156,7 @@ define(
}
function registerExtensionGroup(extensionGroup) {
+ // Register all declared extensions by category
Object.keys(extensionGroup).forEach(function (category) {
registerExtensionsForCategory(
category,
@@ -158,6 +164,7 @@ define(
);
});
+ // Also handle categories which are needed but not declared
registerEmptyDependencies(extensionGroup);
// Return the application to which these extensions