[Layout] Update on composition change

Update frame positions when model.composition changes,
instead of when model changes. Ensures correct display
after changes to avoid redrawing on every update,
WTD-716.
This commit is contained in:
Victor Woeltjen
2015-01-27 10:22:50 -08:00
parent 0df809741a
commit 2b4517cff6
2 changed files with 10 additions and 11 deletions

View File

@ -66,9 +66,8 @@ define(
}
// Compute panel positions based on the layout's object model
function lookupPanels(model) {
var configuration = $scope.configuration || {},
ids = (model || {}).composition || [];
function lookupPanels(ids) {
var configuration = $scope.configuration || {};
// Pull panel positions from configuration
rawPositions = shallowCopy(configuration.panels || {}, ids);
@ -77,14 +76,14 @@ define(
positions = {};
// Update width/height that we are tracking
gridSize = (model || {}).layoutGrid || DEFAULT_GRID_SIZE;
gridSize = ($scope.model || {}).layoutGrid || DEFAULT_GRID_SIZE;
// Compute positions and add defaults where needed
ids.forEach(populatePosition);
}
// Position panes when the model field changes
$scope.$watch("model", lookupPanels);
$scope.$watch("model.composition", lookupPanels);
return {
/**