Misc Fixes 3 (#2389)

* Misc Fixes 3

- Fix Chrome 73 bug in overlay __contents-main element;
- Fixed messages by including erroneously missing _legacy-messages.scss
file;
- Better layout for messages in notification overlay list;

* Misc Fixes 3

- Fix about screen for better compatibility with VISTA;
- Better logo sizing in splash element;

platform/commonUI/dialog/res/templates/notification-message.html

@@ -9,6 +9,7 @@
                          ng-model="ngModel"
                          ng-show="ngModel.progressPerc !== undefined"></mct-include>
         </div>
+    </div>
     <div class="c-overlay__button-bar">
         <button ng-repeat="dialogOption in ngModel.options"
                 class="c-button"
@@ -21,5 +22,4 @@
             {{ngModel.primaryOption.label}}
         </button>
     </div>
-    </div>
 </div>

src/api/overlays/components/OverlayComponent.vue

@@ -92,6 +92,7 @@
             display: flex;
             flex-direction: column;
             flex: 1 1 auto;
+            height: 0; // Chrome 73 overflow bug fix
             overflow: auto;
             padding-right: $interiorMargin; // fend off scroll bar
         }

src/styles-new/_about.scss

@@ -54,10 +54,11 @@
 
     &:after {
         // App logo
-        top: 0;
+        $d: 25%;
-        right: 15%;
+        top: $d;
-        bottom: 0;
+        right: $d;
-        left: 15%;
+        bottom: $d;
+        left: $d;
     }
 }
 
@@ -75,12 +76,20 @@
 
     &__image,
     &__text {
-        height: 50%;
+        flex: 1 1 auto;
-        flex: 1 1 0;
+    }
+
+    &__image {
+        height: 35%;
     }
 
     &__text {
+        height: 65%;
         overflow: auto;
+        > * + * {
+            border-top: 1px solid $colorInteriorBorder;
+            margin-top: 1em;
+        }
     }
 
     &--licenses {
@@ -107,7 +116,7 @@
 
     h1, h2, h3 {
         font-weight: normal;
-        margin-bottom: 1em;
+        margin-bottom: .25em;
     }
 
     h1 {

src/styles-new/core.scss

@@ -33,3 +33,4 @@
 @import "table";
 @import "legacy";
 @import "legacy-plots";
+@import "legacy-messages";

src/ui/layout/AboutDialog.vue

@@ -1,9 +1,9 @@
 <template>
 <div class="c-about c-about--splash">
-    <div v-if="!branding.aboutHtml" class="c-about__image c-splash-image"></div>
+    <div class="c-about__image c-splash-image"></div>
-
     <div class="c-about__text s-text">
-        <div v-if="branding.aboutHtml" class="s-text l-content" v-html="branding.aboutHtml"></div>
+        <div class="c-about__text__element" v-if="branding.aboutHtml" v-html="branding.aboutHtml"></div>
+        <div class="c-about__text__element">
             <h1 class="l-title s-title">Open MCT</h1>
             <div class="l-description s-description">
                 <p>Open MCT, Copyright &copy; 2014-2019, United States Government as represented by the Administrator of the National Aeronautics and Space Administration. All rights reserved.</p>
@@ -19,6 +19,7 @@
                 <li>Branch: {{buildInfo.branch || 'Unknown'}}</li>
             </ul>
         </div>
+    </div>
 </div>
 </template>
 <script>