ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-06-05 00:50:49 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fixes tests

Browse Source
This commit is contained in:
Joshi 2020-02-19 12:51:15 -08:00
parent f4468a8233
commit 0ad2d59924
2 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/condition/ConditionSpec.js
View File

@ -64,14 +64,14 @@ describe("The condition", function () {
openmct.telemetry.getMetadata.and.returnValue(testTelemetryObject.telemetry.values); openmct.telemetry.getMetadata.and.returnValue(testTelemetryObject.telemetry.values);
testConditionDefinition = { testConditionDefinition = {
definition: { configuration: {
trigger: TRIGGER.ANY, trigger: TRIGGER.ANY,
criteria: [ criteria: [
{ {
operation: 'equalTo', operation: 'equalTo',
input: false, input: false,
metaDataKey: 'value', metadata: 'value',
key: testTelemetryObject.identifier telemetry: testTelemetryObject.identifier
} }
] ]
} }
@ -87,13 +87,13 @@ describe("The condition", function () {
}); });
it("generates criteria with an id", function () { it("generates criteria with an id", function () {
const testCriterion = testConditionDefinition.definition.criteria[0]; const testCriterion = testConditionDefinition.configuration.criteria[0];
let criterion = conditionObj.generateCriterion(testCriterion); let criterion = conditionObj.generateCriterion(testCriterion);
expect(criterion.id).toBeDefined(); expect(criterion.id).toBeDefined();
expect(criterion.operation).toEqual(testCriterion.operation); expect(criterion.operation).toEqual(testCriterion.operation);
expect(criterion.input).toEqual(testCriterion.input); expect(criterion.input).toEqual(testCriterion.input);
expect(criterion.metaDataKey).toEqual(testCriterion.metaDataKey); expect(criterion.metadata).toEqual(testCriterion.metadata);
expect(criterion.key).toEqual(testCriterion.key); expect(criterion.telemetry).toEqual(testCriterion.telemetry);
}); });
it("initializes with an id", function () { it("initializes with an id", function () {
@ -104,13 +104,13 @@ describe("The condition", function () {
expect(conditionObj.criteria.length).toEqual(1); expect(conditionObj.criteria.length).toEqual(1);
let criterion = conditionObj.criteria[0]; let criterion = conditionObj.criteria[0];
expect(criterion instanceof TelemetryCriterion).toBeTrue(); expect(criterion instanceof TelemetryCriterion).toBeTrue();
expect(criterion.operator).toEqual(testConditionDefinition.definition.criteria[0].operator); expect(criterion.operator).toEqual(testConditionDefinition.configuration.criteria[0].operator);
expect(criterion.input).toEqual(testConditionDefinition.definition.criteria[0].input); expect(criterion.input).toEqual(testConditionDefinition.configuration.criteria[0].input);
expect(criterion.metaDataKey).toEqual(testConditionDefinition.definition.criteria[0].metaDataKey); expect(criterion.metadata).toEqual(testConditionDefinition.configuration.criteria[0].metadata);
}); });
it("initializes with the trigger from the condition definition", function () { it("initializes with the trigger from the condition definition", function () {
expect(conditionObj.trigger).toEqual(testConditionDefinition.definition.trigger); expect(conditionObj.trigger).toEqual(testConditionDefinition.configuration.trigger);
}); });
it("destroys all criteria for a condition", function () { it("destroys all criteria for a condition", function () {

4
src/plugins/condition/criterion/TelemetryCriterionSpec.js
View File

@ -64,7 +64,7 @@ describe("The telemetry criterion", function () {
testCriterionDefinition = { testCriterionDefinition = {
id: 'test-criterion-id', id: 'test-criterion-id',
key: openmct.objects.makeKeyString(testTelemetryObject.identifier) telemetry: openmct.objects.makeKeyString(testTelemetryObject.identifier)
}; };
mockListener = jasmine.createSpy('listener'); mockListener = jasmine.createSpy('listener');
@ -85,7 +85,6 @@ describe("The telemetry criterion", function () {
it("initializes with a telemetry objectId as string", function () { it("initializes with a telemetry objectId as string", function () {
telemetryCriterion.initialize(testTelemetryObject); telemetryCriterion.initialize(testTelemetryObject);
expect(telemetryCriterion.telemetryObjectIdAsString).toEqual(testTelemetryObject.identifier.key); expect(telemetryCriterion.telemetryObjectIdAsString).toEqual(testTelemetryObject.identifier.key);
expect(telemetryCriterion.telemetryMetadata.length).toEqual(2);
expect(mockListener2).toHaveBeenCalled(); expect(mockListener2).toHaveBeenCalled();
}); });
@ -112,7 +111,6 @@ describe("The telemetry criterion", function () {
expect(telemetryCriterion.subscription).toBeUndefined(); expect(telemetryCriterion.subscription).toBeUndefined();
expect(telemetryCriterion.telemetryObjectIdAsString).toBeUndefined(); expect(telemetryCriterion.telemetryObjectIdAsString).toBeUndefined();
expect(telemetryCriterion.telemetryObject).toBeUndefined(); expect(telemetryCriterion.telemetryObject).toBeUndefined();
expect(telemetryCriterion.telemetryMetadata).toBeUndefined();
}); });
}); });