From 0a39984c4fbec0807b77663fe44901c536acd691 Mon Sep 17 00:00:00 2001 From: Shivam Dave Date: Wed, 5 Aug 2015 12:26:09 -0700 Subject: [PATCH] [Mobile] Clean Up Fixed InfoService having 0 in wrong spot. Also correctly compared the UserAgent device to iPhone for isMobile function in AgentService. --- platform/commonUI/general/src/services/AgentService.js | 2 +- platform/commonUI/inspect/src/services/InfoService.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/platform/commonUI/general/src/services/AgentService.js b/platform/commonUI/general/src/services/AgentService.js index 307446c1dc..0d43cfdfa6 100644 --- a/platform/commonUI/general/src/services/AgentService.js +++ b/platform/commonUI/general/src/services/AgentService.js @@ -59,7 +59,7 @@ define( // phone is designated as only an // iPhone device function isPhone(ua) { - if (getDeviceUA(ua) == "iPhone") { + if (getDeviceUA(ua)[0] === "iPhone") { return true; } else { return false; diff --git a/platform/commonUI/inspect/src/services/InfoService.js b/platform/commonUI/inspect/src/services/InfoService.js index ab1a6a5d15..a7c1c19a1e 100644 --- a/platform/commonUI/inspect/src/services/InfoService.js +++ b/platform/commonUI/inspect/src/services/InfoService.js @@ -62,10 +62,10 @@ define( // to where clicked or pressed) bubble.css('position', 'absolute'); if (agentService.isPhone(navigator.userAgent)) { - bubble.css('right', 0 + 'px'); - bubble.css('left', 0 + 'px'); + bubble.css('right', '0px'); + bubble.css('left', '0px'); bubble.css('top', 'auto'); - bubble.css('bottom', 25 + 'px'); + bubble.css('bottom', '25px'); } else { if (goLeft) { bubble.css('right', (winDim[0] - position[0] + OFFSET[0]) + 'px');