ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2024-12-24 07:16:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Time Conductor] Fix throttle bug

Browse Source 
Fix a timing/ordering issue in throttle which
allowed some throttled invocations to be ignored.
WTD-1515
This commit is contained in:
Victor Woeltjen 2015-09-16 11:04:07 -07:00
parent 7a97588aa5
commit 071368c3b9
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
platform/core/src/services/Throttle.js
View File

@ -61,18 +61,14 @@ define(
* @memberof platform/core.Throttle#
*/
return function (fn, delay, apply) {
var activeTimeout,
var promise, // Promise for the result of throttled function
args = [];
// Clear active timeout, so that next invocation starts
// a new one.
function clearActiveTimeout() {
activeTimeout = undefined;
}
// Invoke the function with the latest supplied arguments.
function invoke() {
fn.apply(null, args);
// Clear the active timeout so a new one starts next time.
promise = undefined;
// Invoke the function with the latest supplied arguments.
return fn.apply(null, args);
}
// Defaults
@ -83,13 +79,10 @@ define(
// Store arguments from this invocation
args = Array.prototype.slice.apply(arguments, [0]);
// Start a timeout if needed
if (!activeTimeout) {
activeTimeout = $timeout(invoke, delay, apply);
activeTimeout.then(clearActiveTimeout);
}
promise = promise || $timeout(invoke, delay, apply);
// Return whichever timeout is active (to get
// a promise for the results of fn)
return activeTimeout;
return promise;
};
};
}