test(e2e): Major refactor and stabilization of e2e tests (#7581)

* fix: update broken locator

* update eslint package

* first pass of lint fixes

* update package

* change ruleset

* update component tests to match linting rules

* driveby

* start to factor out bad locators

* update gauge component

* update notebook snapshot drop area

* Update plot aria

* add draggable true to tree items

* update package

* driveby to remove dead code

* unneeded

* unneeded

* tells a screenreader that this is a row and a cell

* adds an id for dragondrops

* this should be a button

* first pass at fixing tooltip selectors

* review comments

* Updating more tests

* update to remove expect expect given our use of check functions

* add expand component

* move role around

* update more locators

* force

* new local storage

* remove choochoo steps

* test: do `lint:fix` and also add back accidentally removed code

* test: add back more removed code

* test: remove `unstable` annotation from tests which are not unstable

* test: remove invalid test-- the "new" time conductor doesn't allow for millisecond changes in fixed time

* test: fix unstable gauge test

* test: remove useless asserts-- this was secretly non-functional. now that we've fixed it, it makes no sense and just fails

* test: add back accidentally removed changes

* test: revert changes that break test

* test: more fixes

* Remove all notion of the unstable/stable e2e tests

* test: eviscerate the flake with FACTS and LOGIC

* test: fix anotha one

* lint fixes

* test: no need to wait for save dialog

* test: fix more tests

* lint: fix more warnings

* test: fix anotha one

* test: use `toHaveLength` instead of `.length).toBe()`

* test: stabilize tabs view example imagery test

* fix: more tests be fixed

* test: more `toHaveCount()`s please

* test: revert more accidentally removed fixes

* test: fix selector

* test: fix anotha one

* update lint rules to clean up bad locators in shared fixtures

* update and remove bad appActions

* test: fix some restricted notebook tests

* test: mass find/replace to enforce `toHaveCount()` instead of `.count()).toBe()`

* Remove some bad appActions and update text

* test: fix da tree tests

* test: await not await await

* test: fix upload plan appAction and add a11y

* Updating externalFixtures with best practice locators and add missing appAction framework tests

* test: fix test

* test: fix appAction test for plans

* test: yum yum fix'em up and get rid of some dragon drops

* fix: alas, a `.only()` got my hopes up that i was done fixing tests

* test: add `setTimeConductorMode` test "suite" which covers most TC related appActions

* test: fix arg

* test(couchdb): fix some network tests via expect polling

* Stabalize visual test

* getCanasPixels

* test: stabilize tooltip telemetry table test, better a11y for tooltips

* chore: update to use `docker compose` instead of `docker-compose`

* New rules, new tests, new me

* fix sort order

* test: add `waitForPlotsToRender` framework test, passthru timeout override

* test: remove `clockOptions` test as we have `page.clock` now

* test: refactor out `overrideClock`

* test: use `clock.install` instead

* test: use `clock.install` instead

* time clock fix

* test: fix timer tests

* remove ever reference to old base fixture

* test: stabilize restricted notebook test

* lint fixes

* test: use clock.install

* update timelist

* test: update visual tests to use `page.clock()`, update snapshots

* test: stabilize tree renaming/reordering test

* a11y: add aria-label and role=region to object view

* refactor: use `dragTo`

* refactor: use `dragTo`, other small fixes

* test: use `page.clock()` to stabilize tooltip telemetry table test

* test: use web-first assertion to stabilize staleness test

* test: knock out a few more `page.click`s

* test: destroy all `page.click()`s

* refactor: consistently use `'Ok'` instead of `'OK'` and `'Ok'` mixed

* test: remove gauge aria label

* test: more test fixes

* test: more fixes and refactors

* docs: add comment

* test: refactor all instances of `dragAndDrop`

* test: remove redundant test (covered in previous test steps)

* test: stabilize imagery operations tests for display layout

* chore: remove bad unicorn rule

* chore(lint): remove unused disable directives

---------

Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>

e2e/tests/functional/plugins/notebook/notebook.e2e.spec.js

@@ -259,7 +259,7 @@ test.describe('Notebook export tests', () => {
     const exportedText = await streamToString(readStream);
     expect(exportedText).toContain('Foo bar entry');
   });
-  test.fixme('can export multiple notebook entries as text ', async ({ page }) => {});
+  test.fixme('can export multiple notebook entries as text', async ({ page }) => {});
   test.fixme('can export all notebook entry metdata', async ({ page }) => {});
   test.fixme('can export all notebook tags', async ({ page }) => {});
   test.fixme('can export all notebook snapshots', async ({ page }) => {});
@@ -296,7 +296,7 @@ test.describe('Notebook entry tests', () => {
     await expect(page.getByLabel('Notebook Entry Input')).toBeVisible();
     await expect(page.getByLabel('Notebook Entry', { exact: true })).toHaveClass(/is-selected/);
   });
-  test('When an object is dropped into a notebook, a new entry is created and it should be focused @unstable', async ({
+  test('When an object is dropped into a notebook, a new entry is created and it should be focused', async ({
     page
   }) => {
     // Create Overlay Plot
@@ -320,7 +320,7 @@ test.describe('Notebook entry tests', () => {
     await expect(embed).toHaveClass(/icon-plot-overlay/);
     expect(embedName).toBe(overlayPlot.name);
   });
-  test('When an object is dropped into a notebooks existing entry, it should be focused @unstable', async ({
+  test('When an object is dropped into a notebooks existing entry, it should be focused', async ({
     page
   }) => {
     // Create Overlay Plot
@@ -354,19 +354,19 @@ test.describe('Notebook entry tests', () => {
     await page.goto(notebookObject.url);
 
     await nbUtils.enterTextEntry(page, 'First Entry');
-    await page.hover('text="First Entry"');
-    await page.click('button[title="Delete this entry"]');
-    await page.getByRole('button', { name: 'Ok' }).filter({ hasText: 'Ok' }).click();
-    await expect(page.locator('text="First Entry"')).toBeHidden();
+    await page.getByLabel('Notebook Entry', { exact: true }).hover();
+    await page.getByLabel('Delete this entry').click();
+    await page.getByRole('button', { name: 'Ok', exact: true }).click();
+    await expect(page.getByText('First Entry')).toBeHidden();
     await nbUtils.enterTextEntry(page, 'Another First Entry');
     await nbUtils.enterTextEntry(page, 'Second Entry');
     await nbUtils.enterTextEntry(page, 'Third Entry');
-    await page.hover('[aria-label="Notebook Entry"] >> nth=2');
-    await page.click('button[title="Delete this entry"] >> nth=2');
-    await page.getByRole('button', { name: 'Ok' }).filter({ hasText: 'Ok' }).click();
-    await expect(page.locator('text="Third Entry"')).toBeHidden();
-    await expect(page.locator('text="Another First Entry"')).toBeVisible();
-    await expect(page.locator('text="Second Entry"')).toBeVisible();
+    await page.getByLabel('Notebook Entry', { exact: true }).nth(2).hover();
+    await page.getByLabel('Delete this entry').nth(2).click();
+    await page.getByRole('button', { name: 'Ok', exact: true }).click();
+    await expect(page.getByText('Third Entry')).toBeHidden();
+    await expect(page.getByText('Another First Entry')).toBeVisible();
+    await expect(page.getByText('Second Entry')).toBeVisible();
   });
   test('when a valid link is entered into a notebook entry, it becomes clickable when viewing', async ({
     page
@@ -383,7 +383,7 @@ test.describe('Notebook entry tests', () => {
 
     const validLink = page.locator(`a[href="${TEST_LINK}"]`);
 
-    expect(await validLink.count()).toBe(1);
+    await expect(validLink).toHaveCount(1);
 
     // Start waiting for popup before clicking. Note no await.
     const popupPromise = page.waitForEvent('popup');
@@ -410,7 +410,7 @@ test.describe('Notebook entry tests', () => {
 
     const invalidLink = page.locator(`a[href="${TEST_LINK}"]`);
 
-    expect(await invalidLink.count()).toBe(0);
+    await expect(invalidLink).toHaveCount(0);
   });
   test('when a link is entered, but it is not in the whitelisted urls, it does not become clickable when viewing', async ({
     page
@@ -427,7 +427,7 @@ test.describe('Notebook entry tests', () => {
 
     const invalidLink = page.locator(`a[href="${TEST_LINK}"]`);
 
-    expect(await invalidLink.count()).toBe(0);
+    await expect(invalidLink).toHaveCount(0);
   });
   test('when a valid link with a subdomain and a valid domain in the whitelisted urls is entered into a notebook entry, it becomes clickable when viewing', async ({
     page
@@ -444,7 +444,7 @@ test.describe('Notebook entry tests', () => {
 
     const validLink = page.locator(`a[href="${INVALID_TEST_LINK}"]`);
 
-    expect(await validLink.count()).toBe(1);
+    await expect(validLink).toHaveCount(1);
   });
   test('when a valid secure link is entered into a notebook entry, it becomes clickable when viewing', async ({
     page
@@ -461,7 +461,7 @@ test.describe('Notebook entry tests', () => {
 
     const validLink = page.locator(`a[href="${TEST_LINK}"]`);
 
-    expect(await validLink.count()).toBe(1);
+    await expect(validLink).toHaveCount(1);
 
     // Start waiting for popup before clicking. Note no await.
     const popupPromise = page.waitForEvent('popup');
@@ -494,7 +494,7 @@ test.describe('Notebook entry tests', () => {
     const unsanitizedLink = page.locator(`a[href="${TEST_LINK_BAD}"]`);
 
     expect.soft(await sanitizedLink.count()).toBe(1);
-    expect(await unsanitizedLink.count()).toBe(0);
+    await expect(unsanitizedLink).toHaveCount(0);
   });
   test('Can add markdown to a notebook entry', async ({ page }) => {
     await page.goto(notebookObject.url);