ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-06-13 20:58:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Layout] Update raw positions on drop

Browse Source 
When handling a drop into the layout, store the panel's
new position to the LayoutController's internal table of
raw positions (in addition to writing it to the configuration.)

Avoids https://github.com/nasa/openmctweb/issues/384
This commit is contained in:
Victor Woeltjen
2015-12-08 15:04:34 -08:00
parent ed7e0d8b0a
commit 038322e9aa
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
platform/features/layout/src/LayoutController.js
View File

@ -85,6 +85,8 @@ define(
$scope.commit("Dropped a frame."); $scope.commit("Dropped a frame.");
} }
// Populate template-facing position for this id // Populate template-facing position for this id
self.rawPositions[id] =
$scope.configuration.panels[id];
self.populatePosition(id); self.populatePosition(id);
// Layout may contain embedded views which will // Layout may contain embedded views which will
// listen for drops, so call preventDefault() so // listen for drops, so call preventDefault() so

17
platform/features/layout/test/LayoutControllerSpec.js
View File

@ -274,6 +274,23 @@ define(
expect(parseInt(style.width, 10)).toBeGreaterThan(63); expect(parseInt(style.width, 10)).toBeGreaterThan(63);
expect(parseInt(style.height, 10)).toBeGreaterThan(31); expect(parseInt(style.height, 10)).toBeGreaterThan(31);
}); });
it("updates positions of existing objects on a drop", function () {
var oldStyle;
mockScope.$watchCollection.mostRecentCall.args[1]();
oldStyle = controller.getFrameStyle("b");
expect(oldStyle).toBeDefined();
// ...drop event...
mockScope.$on.mostRecentCall
.args[1](mockEvent, 'b', { x: 300, y: 100 });
expect(controller.getFrameStyle("b"))
.not.toEqual(oldStyle);
});
}); });
} }
); );