From 00d1728dd3e9e262320b61a6b71624b6c9a72bc5 Mon Sep 17 00:00:00 2001
From: Sarah Hale <sarahlauhale@gmail.com>
Date: Wed, 24 Jun 2015 12:07:06 -0700
Subject: [PATCH] [Events] Tweaked tests

Changed some test names to be more descriptive.
Moved the policy test to another folder.
Blanket coverage now works. #18.
---
 .../features/events/test/DomainColumnSpec.js  |  2 +-
 .../events/test/EventListPopulatorSpec.js     |  2 +-
 .../events/test/MessagesViewPolicySpec.js     | 67 -------------------
 .../features/events/test/RangeColumnSpec.js   |  2 +-
 platform/features/events/test/suite.json      |  2 +-
 5 files changed, 4 insertions(+), 71 deletions(-)
 delete mode 100644 platform/features/events/test/MessagesViewPolicySpec.js

diff --git a/platform/features/events/test/DomainColumnSpec.js b/platform/features/events/test/DomainColumnSpec.js
index c63eebc0a9..29c896cd5b 100644
--- a/platform/features/events/test/DomainColumnSpec.js
+++ b/platform/features/events/test/DomainColumnSpec.js
@@ -31,7 +31,7 @@ define(
 
         var TEST_DOMAIN_VALUE = "some formatted domain value";
 
-        describe("A domain column", function () {
+        describe("An event list domain column", function () {
             var mockDataSet,
                 testMetadata,
                 mockFormatter,
diff --git a/platform/features/events/test/EventListPopulatorSpec.js b/platform/features/events/test/EventListPopulatorSpec.js
index b263c003a0..7937714fec 100644
--- a/platform/features/events/test/EventListPopulatorSpec.js
+++ b/platform/features/events/test/EventListPopulatorSpec.js
@@ -86,7 +86,7 @@ define(
                 });
             });
 
-            it("returns rows in reverse domain order", function () {
+            it("returns rows in most-recent-last order", function () {
                 var rows = populator.getRows(mockDatas, mockDomainObjects, 84),
                     previous = Number.NEGATIVE_INFINITY;
 
diff --git a/platform/features/events/test/MessagesViewPolicySpec.js b/platform/features/events/test/MessagesViewPolicySpec.js
deleted file mode 100644
index b2bfc17e3d..0000000000
--- a/platform/features/events/test/MessagesViewPolicySpec.js
+++ /dev/null
@@ -1,67 +0,0 @@
-/*****************************************************************************
- * Open MCT Web, Copyright (c) 2014-2015, United States Government
- * as represented by the Administrator of the National Aeronautics and Space
- * Administration. All rights reserved.
- *
- * Open MCT Web is licensed under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0.
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
- * under the License.
- *
- * Open MCT Web includes source code licensed under additional open source
- * licenses. See the Open Source Licenses file (LICENSES.md) included with
- * this source code distribution or the Licensing information page available
- * at runtime from the About dialog for additional information.
- *****************************************************************************/
-/*global define,describe,it,expect,beforeEach,jasmine*/
-
-/**
- *  EventSpec. Created by shale on 06/24/2015.
- */
-define(
-    ["../src/policies/MessagesViewPolicy"],
-    function (MessagesViewPolicy) {
-        "use strict";
-
-        describe("The messages view policy", function () {
-            var mockDomainObject,
-                testType,
-                policy;
-
-            beforeEach(function () {
-                mockDomainObject = jasmine.createSpyObj(
-                    'domainObject',
-                    ['getModel']
-                );
-                mockDomainObject.getModel.andCallFake(function (c) {
-                    return {type: testType};
-                });
-
-                policy = new MessagesViewPolicy();
-            });
-
-            it("disallows the message view for non Event Generators", function () {
-                testType = 'notAnEventGenerator';
-                expect(policy.allow({ key: 'messages' }, mockDomainObject))
-                    .toBeFalsy();
-            });
-
-            it("allows the message view for Event Generators", function () {
-                testType = 'eventGenerator';
-                expect(policy.allow({ key: 'messages' }, mockDomainObject))
-                    .toBeTruthy();
-            });
-
-            it("returns true when the current view is not the Messages view", function () {
-                expect(policy.allow({ key: 'notMessages' }, mockDomainObject))
-                    .toBeTruthy();
-            });
-        });
-    }
-);
\ No newline at end of file
diff --git a/platform/features/events/test/RangeColumnSpec.js b/platform/features/events/test/RangeColumnSpec.js
index 204e246daf..99c5ceb6f4 100644
--- a/platform/features/events/test/RangeColumnSpec.js
+++ b/platform/features/events/test/RangeColumnSpec.js
@@ -31,7 +31,7 @@ define(
 
         var TEST_RANGE_VALUE = "some formatted range value";
 
-        describe("A range column", function () {
+        describe("An event list range column", function () {
             var mockDataSet,
                 testMetadata,
                 mockFormatter,
diff --git a/platform/features/events/test/suite.json b/platform/features/events/test/suite.json
index e796d65ebb..44c96e9fa6 100644
--- a/platform/features/events/test/suite.json
+++ b/platform/features/events/test/suite.json
@@ -2,6 +2,6 @@
     "DomainColumn",
     "EventListController",
     "EventListPopulator",
-    "MessagesViewPolicy",
+    "policies/MessagesViewPolicy",
     "RangeColumn"
 ]
\ No newline at end of file