Commit Graph

169 Commits

Author SHA1 Message Date
3f35d81f4b Adding New Default Image Config Value to IC. (#2434)
* Adding New Default Image Config Value to IC.

* Removing forced image setting.

* Updating Webhook Events.

* Removing typo.

* Updating webhook_events again.

* Syncing webhook events.

* Fixing check for os type.

* Fixing import.

* PR Suggestions.

* Fix C# Model Typo.

* Removing other refs to images.

* Removing remaining refs to images outside of models.

* Removing hardcoded image values from tests.

* Update Default Proxy and Repro Images.

Co-authored-by: Marc Greisen <mgreisen@microsoft.com>
2022-09-23 10:40:44 -07:00
ef7b557599 Add debug command to download a task’s containers (#2359) 2022-09-09 00:45:15 +00:00
df4edbea98 Coverage task should have access to readonly_inputs (#2352)
Fixes #2348.

Code duplicated & modified from line 112.

Both the generic and dotnet coverage tasks [iterate over all `readonly_inputs` that they are supplied](bd4dfdc592/src/agent/onefuzz-task/src/tasks/coverage/generic.rs (L98-L115)), so this should be sufficient.
2022-09-07 22:15:30 +00:00
44089d32f0 fix broken deploy (#2355)
Co-authored-by: stas <statis@microsoft.com>
2022-09-07 14:49:07 -07:00
dcb706fa6a Changing CLI Scaleset size parameter to max_size. (#2293)
* Changing size parameter to max_size.

* Adding default param for clarity.

* FIxing param

* Setting size to 1.

* Adding comment.

* Trailing white spaces.

* Adding initialized_size param.

* Using initialized_at.

* Changing variable name.
2022-08-26 09:57:51 -07:00
d83723b8ae Properly compare job/task state enums (#2004) 2022-08-22 16:36:56 +12:00
15d92cad52 Retry on "No connection could be made because target machine actively… (#2252)
* Retry on "No connection could be made because target machine actively refused it" when connecting debugger using create_and_connect command

* limit number of retries

Co-authored-by: stas <statis@microsoft.com>
2022-08-15 09:24:26 -07:00
ceb5d6d5f9 Update Default Windows Image (#2226)
* Update Function Scaling Policy and Diagnostic Settings.

* Adding changes to scaling policy

* UPdating cooldown.

* Changing time windows.

* Updating duration.

* Updating Out-of-Date Windows Image.

* Adding repro operations back.

* Removing bad files.
2022-08-08 11:40:55 -07:00
992751044f Make the dotnet endpoint and functions configurable in the cli (#2190) 2022-07-25 22:12:36 +00:00
08fb29fc6b ignore the state when a job_id is specified in tasks list (#2171) 2022-07-21 18:25:39 +00:00
b1a3e7530a Drop support for pre 3.0.0 authentication in the cli (#2173) 2022-07-20 13:28:31 -07:00
d71c558447 allow and set onefuzz cli autoscale min value default to zero (#2112) 2022-07-13 08:59:03 -07:00
3878793147 Trim whitespaces from options passed to executables (#2151)
* Trim whitespaces from options passed to executables

* check for None

* refactor to a function
2022-07-11 23:37:48 +00:00
fb0e055ca9 Add azcopy upload support and switch to the default max_concurrency (#1556)
* Add azcopy copy support and switch to the default max_concurrency

* Modify upload_file_data to use upload_file for consistency

* Fix lint issues

* Apply black formatting rules

* Apply isort formatting rules

Co-authored-by: Stas <stishkin@live.com>
2022-06-30 11:30:52 -07:00
52ccf05a29 Remove deprecated libfuzzer_coverage task (#2021)
- Remove the ability to create or execute a `libfuzzer_coverage` task
- Preserve the enum variant in `onefuzztypes` to prevent errors when deserializing old data
- Remove doc references to `libfuzzer_coverage`
2022-06-13 12:38:35 -07:00
f8ba6e2d5b Specify that the tools are missing locally, not on the repro vm (#2036) 2022-06-09 20:04:08 +00:00
3dd27be55b Use consistent logger names (#1945) 2022-05-15 15:22:53 -07:00
806409bdbf Warn on SDK/CLI creation of libfuzzer_coverage task (#1944)
The old `libfuzzer_coverage` task dumps binary sancov tables. Its output is not usable on its own. This task has been superseded by the generic `coverage` task (which produces actual modoffset and source line coverage).

Add a CLI warning if it is used, in preparation for removing it.
2022-05-14 12:03:09 -07:00
779a67ed6d Download agent logs using sas url (#1920) 2022-05-10 10:54:53 -04:00
25405b0b27 Remove client_secret from config, add env var (#1918) 2022-05-09 16:58:15 -07:00
4be286ada5 bump azure-cli-core and dependencies to 2.35.0 (#1784)
* bump azure-cli-core and dependencies to 2.35.0

* bump deploy requirements to align with cli

Co-authored-by: stas <statis@microsoft.com>
2022-04-19 13:38:40 -07:00
cb45c5685f add tool_name and onfuzz_version to CrashReport (#1635) 2022-04-18 23:56:07 +00:00
0c3d9fcad2 Add CLI command to download agent logs (#1723)
* It does some things

* Download logs from job config

* Lint

* Make mypy happy

* Update to handle the new logs path

* progress

* A job might not have logs set in config

* Mypy wanted a type annotation
2022-04-05 15:35:15 -04:00
424ffdb4b5 Adding auto scale via cli (#1717)
* Initial implementation for adding auto scale via cli

* Remove unused argument

* Remove unused import

* I had a 👻extra line👻
2022-03-29 09:50:07 -04:00
24454e3681 pin click to fix black (#1726)
* pin click to fix black

* missed a couple

Co-authored-by: stas <statis@microsoft.com>
2022-03-28 12:06:13 -07:00
d4c92d497f Add type definition (#1703) 2022-03-09 23:52:06 +00:00
77dcd57b46 Add EventGrid compatible webhook format (#1640) 2022-02-11 16:39:19 -08:00
62731f3836 bump azure-cli-core and azure-cli to 2.32.0 (#1634) 2022-02-02 17:38:46 -08:00
dab0dba34f Fix lint warning (#1631) 2022-01-31 15:59:20 +00:00
b49d140ff0 Add fuzzer_target_options to libfuzzer basic template (#1610) 2022-01-26 20:31:13 -08:00
1731ca4dde Bump requests to 2.27.1 (#1567)
Co-authored-by: stas <statis@microsoft.com>
2022-01-12 07:29:34 -08:00
c5421894c1 bump azure-cli and azure-cli-core to 2.31.0 (#1557)
* bump azure-cli and azure-cli-core to 2.31.0

and all required dependencies

* Update src/cli/onefuzz/cred_wrapper.py

Co-authored-by: Joe Ranweiler <joe@lemma.co>

* updating credential wrapper

* Update src/cli/onefuzz/azure_identity_credential_adapter.py

Co-authored-by: Joe Ranweiler <joe@lemma.co>

* updating credential wrapper

* .

Co-authored-by: stas <statis@microsoft.com>
Co-authored-by: Joe Ranweiler <joe@lemma.co>
2022-01-05 07:11:24 -08:00
1de2cc841d Check-pr creates and uses SP. (#1504)
* Check-pr creates and uses SP.

* flake8.

* flake8.

* Fixing var name.

* Fixing deploy.py

* Looking for client_secret

* Change to check_output.

* mypy fix.

* Fixing check-pr

* working version.

* lint

* Updating arg text.

* Removing redundant functionality.

* Changing register codepath and adding flag.

* Removing pycache file.

* Fixing unattended flag.

* Adding space.

* Fixing a few calls.

* Removing file.

* Removing python3.

* Removing old file.

* Adding wait into registration.py

* Formatting registration.py.

* Removing space.

* Adding retry logic to check-pr.

* Formatting.

* Retriggering.

* Retriggering.

* Calling sp_create and adding retry to authorize.

* Fixing syntax.

* Removing comments.

* Adding another retry.

* Retriggering.

* Retriggering.

* Retriggering.

* Trying to find error.

* Adding retry logic.

* Increasing sleep.

* Fixing formatting.

* Retriggering.

* Removing bad file.

* Trying out retry for logger.

* typevar issue?

* Re-adding.

* Retriggering.

* retriggering.

* Retriggering.

Co-authored-by: nharper285 <nharper285@gmail.com>
Co-authored-by: Cheick Keita <kcheick@gmail.com>
2021-12-17 09:44:04 -08:00
bb972c22f4 pin mypy to 0.910 (#1531)
https://github.com/samuelcolvin/pydantic/issues/3528

https://github.com/python/mypy/issues/6617#issuecomment-892438903
https://github.com/samuelcolvin/pydantic/pull/3175#issuecomment-914897604

updating mypy in build yml and requirements to 0.910

Co-authored-by: stas <statis@microsoft.com>
2021-12-16 14:13:54 -08:00
7cabc6b924 Remove generic reset command (#1511)
* Remove generic reset command

Remove ability to reset containers by type.
Work item #1508

* Test to see if we are getting timeouts when attempting to get a queue message.

* Remove exception handling for timeout.
2021-12-13 17:21:39 -08:00
2f136d4b8e exposing the target_timeout paramter through the radamsa template (#1499) 2021-12-01 19:22:45 +00:00
7c86a3d7d9 Fix client_secret auth (#1376)
- Stop strying new scopes when encountering an unexpected error
2021-10-26 11:27:24 -07:00
98578da557 catch up SDK version in examples to OneFuzz released version (#1396)
Co-authored-by: stas <statis@microsoft.com>
2021-10-26 08:26:01 -07:00
98cd7c9c56 migrate to msgraph (#966)
* migrate to msgraph

* add subscription id to query_microsoft_graph

* migrating remaingin references

* formatting

* adding missing dependencies

* flake fix

* fix get_tenant_id

* cleanup

* formatting

* migrate application creation in deploy.py

* foramt

* mypy fix

* isort

* isort

* format

* bug fixes

* specify the correct signInAudience

* fix backing service principal creation
fix preauthorized application

* remove remaining references to graphrbac

* fix ms graph authentication

* formatting

* fix typo

* format

* deployment fix

* set implicitGrantSettings in the deployment

* format

* fix deployment

* fix graph authentication on the server

* use the current cli logged in account to retrive the backend token cache

* assign the the msgraph app role permissions to the web app during the deployment

* formatting

* fix build

* build fix

* fix bandit issue

* mypy fix

* isort

* deploy fixes

* formatting

* remove assign_app_permissions

* mypy fix

* build fix

* mypy fix

* format

* formatting

* flake fix

* remove webapp identity permission assignment

* remove unused reference to assign_app_role

* remove manual registration message

* fixing name and logging

* address PR coments

* address PR comments

* build fix

* lint

* lint

* mypy fix

* mypy fix

* formatting

* address PR comments

* linting

* lint

* remove ONEFUZZ_AAD_GROUP_ID check

* regenerate webhook_events.md

* change return type of query_microsoft_graph_list

* fix tenant_id

Co-authored-by: Marc Greisen <marc@greisen.org>
Co-authored-by: Stas <stishkin@live.com>
2021-10-22 11:59:05 -07:00
e5c3e60b8a Bump azure cli to 2.27.2 (#1355)
* Bump azure cli to 2.27.2

* fixing up add-corpus-storage-account script

Co-authored-by: stas <statis@microsoft.com>
2021-10-13 11:27:48 -07:00
ddd82f9931 Fix authentication with client secret (#1300)
* Fix authenticatio
2021-09-29 15:56:32 -07:00
d3bcbea980 Increase default level of feedback/confirmation in destructive commands #1264 (#1283)
Co-authored-by: stas <statis@microsoft.com>
2021-09-27 09:59:56 -07:00
d034664cb3 update msal to 1.14.0 (#1278) 2021-09-24 16:45:03 +00:00
9413377c90 handle fake crash reports generated by debugging tools in regression tasks (#1233) 2021-09-22 17:16:35 +00:00
80456f1237 Added support for --readonly_inputs for libfuzzer basic template (#1247) 2021-09-21 16:51:25 +00:00
84bb5d0105 temporarily ignore type errors from azure-storage-blob (#1258) 2021-09-21 11:42:41 -04:00
2e267a894f Move to using api:// for AAD Application "identifier uris" (#1243) 2021-09-17 14:04:19 -04:00
f569bc8427 fix rendering SecretData for jmespath filtering (#1223)
Co-authored-by: Brian Caswell <bmc@shmoo.com>
2021-09-03 16:39:44 -04:00
e138945467 Fix rendering datetime and None in CLI (#1221) 2021-09-02 16:32:14 +00:00
77434e476a resolve set as list for passing to jmespath (#1208)
Co-authored-by: Brian Caswell <bmc@shmoo.com>
2021-08-30 20:39:49 +00:00