1894 Commits

Author SHA1 Message Date
Teo Voinea
572671b58e
Sematically validate notification configs (#2850)
* Add new command

* Update remaining jinja templates and references to use scriban

* Add ado template validation

* Validate ado and github templates

* Remove unnecessary function

* Update src/ApiService/ApiService/OneFuzzTypes/Model.cs

Co-authored-by: Cheick Keita <kcheick@gmail.com>

---------

Co-authored-by: Cheick Keita <kcheick@gmail.com>
2023-02-16 18:08:30 +00:00
George Pollard
124f50ded6
Report extension errors (#2846)
Old failure message:
```
failed to launch extension
```

New failure message:

```
failed to launch extension(s): Errors for extension 'CustomScriptExtension':
:Error: ProvisioningState/failed/3 (Provisioning failed) - Failed to download all specified files. Exiting. Error Message: The remote server returned an error: (400) Bad Request.
```
2023-02-16 16:04:59 +13:00
George Pollard
f3524c37aa
Fix error reporting for creating a Scaleset under a missing Pool (#2844) 2023-02-15 22:32:21 +00:00
George Pollard
5ea0128727
Add --notification_config support for dotnet templates (#2842) 2023-02-16 10:54:58 +13:00
Joe Ranweiler
58f756de47
Switch over to new coverage task (#2741) 2023-02-15 12:41:19 -08:00
Teo Voinea
2d59a2a5ca
Support another case when adding AssignedTo to telemetry (#2829)
* Add new command

* Catch another case
2023-02-15 19:24:11 +00:00
Teo Voinea
32cdf8b738
Sets EnableScriban to false by default at deployment time (#2839) 2023-02-15 18:58:49 +00:00
Teo Voinea
e9f5a6a2e7
Validate scriban on new notifications (#2834)
* Add new command

* Enforce scriban at notification creation time

* fmt

* missed when merging
2023-02-15 13:16:01 -05:00
Joe Ranweiler
21374b36e6
Defer setting coverage breakpoints (#2832) 2023-02-14 10:52:08 -08:00
Joe Ranweiler
0c58a59011
Fix coverage example build (#2831) 2023-02-14 07:54:19 -08:00
Joe Ranweiler
bb82580a1f
Add function allowlist to coverage example exe (#2830) 2023-02-14 07:25:10 -08:00
Teo Voinea
307526fb64
[Breaking Change] Deploy with scriban only turned on (#2809)
* Deploy with scriban only turned on

* Improve description
2023-02-14 13:31:39 +00:00
Noah McGregor Harper
0bc22a8073
Fixing bug in registration.py for creating CLI SP's. (#2828)
* Fixing bug in registration.py for creating CLI SP's.

* Formatting.
2023-02-10 15:11:35 -08:00
Joe Ranweiler
85fe434b3e
Remove stray print statement (#2823) 2023-02-10 14:31:34 -08:00
Teo Voinea
2e6eef7654
Add notification get command (#2818)
* Add new command

* lint
2023-02-09 11:30:40 -05:00
Teo Voinea
a13bb2feb3
Interact with migrations via cli (#2816)
* Interact with migrations via cli

* Move command under notifications
2023-02-08 22:02:40 +00:00
Cheick Keita
f13f52ab71
Deprecating the job template feature (#2798)
* deprecating the job template feature

* removing the code

* format
2023-02-08 19:21:03 +00:00
Cheick Keita
d732028201
Add unmanaged nodes integration tests (#2780)
* Add docker file to the runtime tools

* fixes

* bug fixes

* more bug fixes and added doc

* don;t overwrite the RUST_LOG env var

* integration test for unmanaged nodes

* add unamanged parameters to launch()

* add ing object_id

* more bug fixes

* bug fixes

* chmod on the linux files in docker

* format

* cleanup merge

* added test_unmanaged command

* cleanup

* use a single image for the docker compose
remove images after the test

* docs and formatting

* format

* format

* format and bug fixes

* using windows server

* fix linux container
make the base image a paramter on windows
use the windows server base image on  windows server

* format

* bug fix

* more fixes

* allow reboot

* more fixes

* added more logging around the service principal creation

* format

* more logging

* change restart policy

* fix multi tenant domain

* more fixes

* exit instead of reboot when running inside docker

* remove comment

* build fix

* try_exist instead of exist

* save the docker logs

* bug_fix

* adding timeout

* fix timeout logic

* adding a build profile

* make all agent depend on the first one

* remove profile

* another fix

* restart agent 1

* Update docs/unmnaged-nodes.md

Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>

---------

Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>
2023-02-08 11:07:19 -08:00
Noah McGregor Harper
f93c75556d
Resolving bug in config refactor. (#2811)
* Resolving bug in config refactor.

* fixing isort.

* Reformatting api.

* debugging.

* fixing backend.

* Adding condition to param retrieval.

* Adding back save.

* Fixing condition check.

* Formatting.
2023-02-07 18:13:29 -08:00
dependabot[bot]
fed7e6939d
Update azure_* packages in agent (#2807)
* Bump azure_storage_blobs from 0.7.0 to 0.9.0 in /src/agent

Bumps [azure_storage_blobs](https://github.com/azure/azure-sdk-for-rust) from 0.7.0 to 0.9.0.
- [Release notes](https://github.com/azure/azure-sdk-for-rust/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-rust/blob/main/HISTORY.md)
- [Commits](https://github.com/azure/azure-sdk-for-rust/commits)

---
updated-dependencies:
- dependency-name: azure_storage_blobs
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update other Azure packages

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: George Pollard <gpollard@microsoft.com>
2023-02-07 22:12:56 +00:00
Noah McGregor Harper
2ab07ef21b
Upgrade openssl. (#2812)
https://rustsec.org/advisories/RUSTSEC-2023-0006
https://rustsec.org/advisories/RUSTSEC-2023-0007
https://rustsec.org/advisories/RUSTSEC-2023-0009
https://rustsec.org/advisories/RUSTSEC-2023-0010
2023-02-07 20:50:06 +00:00
dependabot[bot]
c52b0bab79
Bump quick-xml from 0.26.0 to 0.27.1 in /src/agent (#2808)
Bumps [quick-xml](https://github.com/tafia/quick-xml) from 0.26.0 to 0.27.1.
- [Release notes](https://github.com/tafia/quick-xml/releases)
- [Changelog](https://github.com/tafia/quick-xml/blob/master/Changelog.md)
- [Commits](https://github.com/tafia/quick-xml/compare/v0.26.0...v0.27.1)

---
updated-dependencies:
- dependency-name: quick-xml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-08 09:00:31 +13:00
dependabot[bot]
c5700b4a34
Bump os_pipe from 1.0.0 to 1.1.3 in /src/agent (#2795)
Bumps [os_pipe](https://github.com/oconnor663/os_pipe.rs) from 1.0.0 to 1.1.3.
- [Release notes](https://github.com/oconnor663/os_pipe.rs/releases)
- [Commits](https://github.com/oconnor663/os_pipe.rs/compare/1.0.0...1.1.3)

---
updated-dependencies:
- dependency-name: os_pipe
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-07 12:50:47 +13:00
dependabot[bot]
d6fed9dc7d
Bump num_cpus from 1.13.1 to 1.15.0 in /src/agent (#2717)
Bumps [num_cpus](https://github.com/seanmonstar/num_cpus) from 1.13.1 to 1.15.0.
- [Release notes](https://github.com/seanmonstar/num_cpus/releases)
- [Changelog](https://github.com/seanmonstar/num_cpus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/seanmonstar/num_cpus/compare/v1.13.1...v1.15.0)

---
updated-dependencies:
- dependency-name: num_cpus
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-06 20:39:31 +00:00
George Pollard
80e9b737e8
Add readonly_inputs to dotnet & dotnet_dll templates (#2740)
Closes #2739
2023-02-06 20:15:21 +00:00
Teo Voinea
c1f6dfc366
Validate scriban from cli (#2800)
* Add validate scriban endpoint to cli

* missed a file

* Lint -- I miss C#

* docs
2023-02-06 08:32:49 -05:00
Cheick Keita
8f418f692c
fix default value of analyzer_exe (#2797) 2023-02-03 00:32:33 +00:00
George Pollard
3ccb599c19
Update tokio to fix RUSTSEC-2023-0005 (#2796)
Fixing build failure, see: https://rustsec.org/advisories/RUSTSEC-2023-0005
2023-02-02 23:49:27 +00:00
George Pollard
949c579deb
Add cobertura output to coverage example (#2777)
This makes it very easy to generate Cobertura reports.

Replace `--source` flag argument with `--output={mod-off, source, cobertura}` (default is still `mod-off`).
2023-02-02 22:12:08 +00:00
Teo Voinea
73fac638d1
Scriban to jinja migration script (#2787)
* .

* fmt

* Testing time

* .

* fmt

* More tests

* More tests

* Cleanup

---------

Co-authored-by: George Pollard <gpollard@microsoft.com>
2023-02-02 21:29:55 +00:00
George Pollard
840ced57df
Check agent binary dependencies in CI (#2792)
Check the list of dynamic dependencies of the agent binaries to ensure we don't accidentally take a dependency on some new or unknown library.
2023-02-02 16:12:26 -05:00
Noah McGregor Harper
457eb1e906
Adding Notification Failure Webhook. (#2628)
* Adding Notification Failure Webhook.

* Typo.

* Add await.
2023-02-02 10:31:13 -08:00
Cheick Keita
291f9dfbcf
Fix query to get he existing proxy (#2791) 2023-02-01 20:49:14 +00:00
Justin Moore
f209c0b2f4
Trim output from monitored process before logging (#2782) 2023-02-01 02:06:54 +00:00
George Pollard
be43032bf5
Fixes & improvements to Expand behaviour (#2789)
- Recursively expand Paths before canonicalization; fixes #2387
- Detect and error on infinitely-expanding variables (due to self-reference or mutual recursion); this fixes an existing problem with list expansion as well
- Detect and report references to unknown replacements (e.g. typoes)
- Detect and report references to _known_ replacements which are not available

---

There is a behavioural change here which is that values which were previously unknown such as `{x}` were unexpanded; from now on these will be errors. It's possible that something somewhere is relying on this.
2023-01-31 23:55:53 +00:00
Noah McGregor Harper
f402304084
Config Refactor Round 2. (#2771)
* Config Refactor Round 2.

* Adding docs.

* Fix file formatting.

* Removing.

* fixing imports.

* Removing.

* Fixing cli access token retrieval.

* Fixing authority check.

* Small edits.

* Removing duplicate.

* Adding uuid check.

* Possible to override with existing params.

* Allowing flags to override storage.

* Trying to fix config params.?

* Fixing.

* Set endpoint params via app function.

* Checking changes to params.

* Make tenant_domain default.

* Remove endoint params from models.

* UPdating docs.

* Setting

* Removing hardcoded values.

* Typo.

* Removing endpoint upload.

* Typo.

* Fixing typos.

* Fix error message about aad tenant.

* Responding to comments.

* Update src/ApiService/ApiService/UserCredentials.cs

Co-authored-by: Marc Greisen <mgreisen@microsoft.com>

---------

Co-authored-by: Marc Greisen <mgreisen@microsoft.com>
2023-01-31 15:03:38 -08:00
Teo Voinea
3d2fb65c14
Truncate for queue as well + bug fix (#2788) 2023-01-31 17:41:59 +00:00
Cheick Keita
bc57fa016c
Add dockerfile to the runtime tools (#2730)
* Add docker file to the runtime tools

* fixes

* bug fixes

* more bug fixes and added doc

* don;t overwrite the RUST_LOG env var

* integration test for unmanaged nodes

* add unamanged parameters to launch()

* add ing object_id

* more bug fixes

* bug fixes

* chmod on the linux files in docker

* format

* revert changes in  integration tests

* Apply suggestions from code review

Co-authored-by: Marc Greisen <mgreisen@microsoft.com>

* format and bug fix

* fix condition

---------

Co-authored-by: Marc Greisen <mgreisen@microsoft.com>
2023-01-30 20:33:11 -08:00
Joe Ranweiler
c7ba712de0
Apply allowlist to all blocks within a function (#2785) 2023-01-30 09:46:58 -08:00
Joe Ranweiler
6d36f5194a
Fully escape allowlist rules (#2784) 2023-01-30 07:14:31 -08:00
Teo Voinea
6829318d67
Include AssignedTo when failing to create a work item due to an authentication exception (#2770)
* In authenticate exceptions, include the identity that the WI would have been assigned to

* Allow querying for a single notification by id
2023-01-27 16:08:06 +00:00
George Pollard
00031156bc
Rust 1.67 (#2781)
Mostly automated `clippy` fixes.
2023-01-27 16:00:24 +13:00
Cheick Keita
7de23af60c
delete python function (#2763)
* delete python function

* fix build
2023-01-25 22:05:55 +00:00
Joe Ranweiler
d79e6d9864
Convert callback errors to recording errors (#2772) 2023-01-24 18:46:56 -08:00
Cheick Keita
a3ceb2dec7
Another fix to the regression parsing (#2758)
* Another fix to the regression parsing

* unit tests

* format
2023-01-23 15:27:05 -08:00
Joe Ranweiler
2bff511f52
Add stdio dumping to example (#2757)
* Add stdio dumping to example

* Format
2023-01-22 21:07:31 +00:00
Joe Ranweiler
5adaadd0ce
Support allowlist extension (#2756)
* Support allowlist extension

* Address lint
2023-01-23 09:52:44 +13:00
Cheick Keita
0cdb0c3a92
fix report parsing (#2755)
* fix report parsing

* message parsing fix in the agent

* formatting
2023-01-20 20:08:25 -08:00
Joe Ranweiler
3f865e245a
Add sourceline output and logging to coverage example (#2753) 2023-01-19 17:26:24 -08:00
Joe Ranweiler
62a0dd695a
Fix Linux detection of shared library mappings (#2754) 2023-01-19 16:59:18 -08:00