ExternalVendorCode/onefuzz
1
0
Fork 0
mirror of https://github.com/microsoft/onefuzz.git synced 2025-06-17 04:18:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

don't schedule work to a node if the scaleset or pool is shutting down (#583)

Browse Source
This commit is contained in:
bmc-msft
2021-02-23 13:33:41 -05:00
committed by GitHub
parent e7fe099f25
commit fb482e357e
1 changed files with 40 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/api-service/__app__/onefuzzlib/workers/nodes.py
View File

@ -8,7 +8,7 @@ import logging
from typing import List, Optional, Tuple from typing import List, Optional, Tuple
from uuid import UUID from uuid import UUID
from onefuzztypes.enums import ErrorCode, NodeState, TaskState from onefuzztypes.enums import ErrorCode, NodeState, PoolState, ScalesetState, TaskState
from onefuzztypes.events import ( from onefuzztypes.events import (
EventNodeCreated, EventNodeCreated,
EventNodeDeleted, EventNodeDeleted,
@ -241,6 +241,9 @@ class Node(BASE_NODE, ORMMixin):
return False return False
def can_process_new_work(self) -> bool: def can_process_new_work(self) -> bool:
from .pools import Pool
from .scalesets import Scaleset
if self.is_outdated(): if self.is_outdated():
logging.info( logging.info(
"can_schedule agent and service versions differ, stopping node. " "can_schedule agent and service versions differ, stopping node. "
@ -279,6 +282,42 @@ class Node(BASE_NODE, ORMMixin):
logging.info("node scheduled to shrink. machine_id:%s", self.machine_id) logging.info("node scheduled to shrink. machine_id:%s", self.machine_id)
return False return False
if self.scaleset_id:
scaleset = Scaleset.get_by_id(self.scaleset_id)
if isinstance(scaleset, Error):
logging.info(
"can_schedule - invalid scaleset. scaleset_id:%s machine_id:%s",
self.scaleset_id,
self.machine_id,
)
return False
if scaleset.state not in ScalesetState.available():
logging.info(
"can_schedule - scaleset not available for work. "
"scaleset_id:%s machine_id:%s",
self.scaleset_id,
self.machine_id,
)
return False
pool = Pool.get_by_name(self.pool_name)
if isinstance(pool, Error):
logging.info(
"can_schedule - invalid pool. " "pool_name:%s machine_id:%s",
self.pool_name,
self.machine_id,
)
return False
if pool.state not in PoolState.available():
logging.info(
"can_schedule - pool is not available for work. "
"pool_name:%s machine_id:%s",
self.pool_name,
self.machine_id,
)
return False
return True return True
def is_outdated(self) -> bool: def is_outdated(self) -> bool: