Remove IDisposable from Creds (#2327)

This commit is contained in:
George Pollard
2022-09-01 10:51:06 +12:00
committed by GitHub
parent 366b671942
commit f7e37355d0

View File

@ -40,7 +40,7 @@ public interface ICreds {
public ResourceIdentifier GetScalesetIdentityResourcePath(); public ResourceIdentifier GetScalesetIdentityResourcePath();
} }
public sealed class Creds : ICreds, IDisposable { public sealed class Creds : ICreds {
private readonly ArmClient _armClient; private readonly ArmClient _armClient;
private readonly DefaultAzureCredential _azureCredential; private readonly DefaultAzureCredential _azureCredential;
private readonly IServiceConfig _config; private readonly IServiceConfig _config;
@ -183,9 +183,6 @@ public sealed class Creds : ICreds, IDisposable {
} }
return resource; return resource;
} }
public void Dispose() {
throw new NotImplementedException();
}
public Task<IReadOnlyList<string>> GetRegions() public Task<IReadOnlyList<string>> GetRegions()
=> _cache.GetOrCreateAsync<IReadOnlyList<string>>( => _cache.GetOrCreateAsync<IReadOnlyList<string>>(