ExternalVendorCode/onefuzz
1
0
Fork 0
mirror of https://github.com/microsoft/onefuzz.git synced 2025-06-11 01:31:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adding handle for missing unique field key in AdoFields (#2986)

Browse Source 
* Adding handle for missing unique field key in .

* Better approach.

* Using TyGetValue.
This commit is contained in:
Noah McGregor Harper 2023-04-07 13:30:29 -07:00 committed by GitHub
parent 1ae063969b
commit e835fb1867
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ApiService/ApiService/onefuzzlib/notifications/Ado.cs
View File

@ -146,15 +146,19 @@ public class Ado : NotificationsBase, IAdo {
} }
} }
public async IAsyncEnumerable<WorkItem> ExistingWorkItems() { public async IAsyncEnumerable<WorkItem> ExistingWorkItems((string, string)[] notificationInfo) {
var filters = new Dictionary<string, string>(); var filters = new Dictionary<string, string>();
foreach (var key in _config.UniqueFields) { foreach (var key in _config.UniqueFields) {
var filter = string.Empty; var filter = string.Empty;
if (string.Equals("System.TeamProject", key)) { if (string.Equals("System.TeamProject", key)) {
filter = await Render(_config.Project); filter = await Render(_config.Project);
} else if (_config.AdoFields.TryGetValue(key, out var field)) {
filter = await Render(field);
} else { } else {
filter = await Render(_config.AdoFields[key]); _logTracer.WithTags(notificationInfo).Error($"Failed to check for existing work items using the UniqueField Key: {key}. Value is not present in config field AdoFields.");
continue;
} }
filters.Add(key.ToLowerInvariant(), filter); filters.Add(key.ToLowerInvariant(), filter);
} }
@ -327,7 +331,7 @@ public class Ado : NotificationsBase, IAdo {
} }
public async Async.Task Process((string, string)[] notificationInfo) { public async Async.Task Process((string, string)[] notificationInfo) {
var matchingWorkItems = await ExistingWorkItems().ToListAsync(); var matchingWorkItems = await ExistingWorkItems(notificationInfo).ToListAsync();
var nonDuplicateWorkItems = matchingWorkItems var nonDuplicateWorkItems = matchingWorkItems
.Where(wi => !IsADODuplicateWorkItem(wi)) .Where(wi => !IsADODuplicateWorkItem(wi))