address clippy warnings (#1125)

.github/workflows/ci.yml

@@ -5,7 +5,7 @@ env:
   CARGO_TERM_COLOR: always
   SCCACHE_DIR: ${{github.workspace}}/sccache/
   SCCACHE_CACHE_SIZE: 1G
-  ACTIONS_CACHE_KEY_DATE: 2021-08-02-01
+  ACTIONS_CACHE_KEY_DATE: 2021-08-06-01
 
 jobs:
   agent:

src/agent/coverage/src/block/pe_provider.rs

@@ -73,7 +73,7 @@ where
     // reverse the instrumented basic blocks.
     fn provide_from_inline_table(&mut self, inline_table: SancovTable) -> Result<BTreeSet<u32>> {
         let mut visitor =
-            SancovInlineAccessVisitor::new(inline_table, &self.data, &self.pe, &mut self.pdb)?;
+            SancovInlineAccessVisitor::new(inline_table, self.data, self.pe, &mut self.pdb)?;
 
         let debug_info = self.pdb.debug_information()?;
         let mut modules = debug_info.modules()?;

src/agent/coverage/src/pe.rs

@@ -259,7 +259,7 @@ fn process_pdb(data: &[u8], pe: &PE, functions_only: bool, pdb_path: &Path) -> R
         &proc_sym_info[..],
         &mut blocks,
         &address_map,
-        &pe,
+        pe,
         data,
         functions_only,
     )?;
@@ -274,7 +274,7 @@ fn process_pdb(data: &[u8], pe: &PE, functions_only: bool, pdb_path: &Path) -> R
                 &proc_sym_info[..],
                 &mut blocks,
                 &address_map,
-                &pe,
+                pe,
                 data,
                 functions_only,
             )?;

src/agent/debugger/src/breakpoint.rs

@@ -275,7 +275,7 @@ impl BreakpointCollection {
     }
 
     fn bulk_write_process_memory(&self, process_handle: HANDLE, buffer: &[u8]) -> Result<()> {
-        process::write_memory_slice(process_handle, self.min_breakpoint_addr as _, &buffer)?;
+        process::write_memory_slice(process_handle, self.min_breakpoint_addr as _, buffer)?;
         process::flush_instruction_cache(
             process_handle,
             self.min_breakpoint_addr as _,

src/agent/input-tester/src/tester.rs

@@ -263,7 +263,7 @@ impl Tester {
             .context("Writing markdown summary for crash/timeout.")?;
 
         // Create a batch file to help reproduce the bug with the settings we used.
-        self.create_repro_bat(&log_dir, &result.input_path, &deduped_input_path)?;
+        self.create_repro_bat(log_dir, &result.input_path, deduped_input_path)?;
 
         Ok(())
     }
@@ -389,7 +389,7 @@ impl Tester {
                     "{}-logs",
                     logs_dir.file_stem().unwrap().to_string_lossy()
                 ));
-                self.create_test_failure_artifacts(&logs_dir, &result, &copied_file)?;
+                self.create_test_failure_artifacts(&logs_dir, result, &copied_file)?;
                 Ok(Some(new_test_result(
                     result.debugger_result.clone(),
                     &result.input_path,

src/agent/win-util/src/lib.rs

@@ -65,8 +65,8 @@ pub fn configure_machine_wide_app_debug_settings(application_path: impl AsRef<Pa
     // This is a machine-wide setting, not process specific.
     wer::disable_wer_ui()?;
 
-    wer::add_exclusion(&exe_name)?;
+    wer::add_exclusion(exe_name)?;
-    aedebug::add_exclusion(&exe_name)?;
+    aedebug::add_exclusion(exe_name)?;
 
     Ok(())
 }