address latest clippy warnings (#679)

src/agent/onefuzz-agent/src/tasks/fuzz/supervisor.rs

@@ -260,7 +260,7 @@ mod tests {
         let runtime_dir = tempfile::tempdir().unwrap();
 
         let supervisor_exe = if let Ok(x) = env::var("ONEFUZZ_TEST_AFL_LINUX_FUZZER") {
-            x.into()
+            x
         } else {
             warn!("Unable to test AFL integration");
             return;

src/agent/onefuzz-agent/src/tasks/generic/input_poller/tests.rs

@@ -100,9 +100,7 @@ fn url_input_name(url: &Url) -> String {
 }
 
 fn fixture() -> InputPoller<Msg> {
-    let task = InputPoller::new();
-
-    task
+    InputPoller::new()
 }
 
 fn url_fixture(msg: Msg) -> Url {

src/agent/onefuzz-supervisor/src/buffer.rs

@@ -44,32 +44,33 @@ impl std::io::Write for TailBuffer {
 
 #[cfg(test)]
 mod tests {
+    use super::*;
+    use anyhow::Result;
     use std::io::Write;
 
-    use super::*;
-
     #[test]
-    fn test_tail_buffer() {
+    fn test_tail_buffer() -> Result<()> {
         let mut buf = TailBuffer::new(5);
 
         assert!(buf.data().is_empty());
 
-        buf.write(&[1, 2, 3]).unwrap();
+        assert_eq!(buf.write(&[1, 2, 3])?, 3);
         assert_eq!(buf.data(), &[1, 2, 3]);
 
-        buf.write(&[]).unwrap();
+        assert_eq!(buf.write(&[])?, 0);
         assert_eq!(buf.data(), &[1, 2, 3]);
 
-        buf.write(&[4, 5]).unwrap();
+        assert_eq!(buf.write(&[4, 5])?, 2);
         assert_eq!(buf.data(), &[1, 2, 3, 4, 5]);
 
-        buf.write(&[6, 7, 8]).unwrap();
+        assert_eq!(buf.write(&[6, 7, 8])?, 3);
         assert_eq!(buf.data(), &[4, 5, 6, 7, 8]);
 
-        buf.write(&[9, 10, 11, 12, 13]).unwrap();
+        assert_eq!(buf.write(&[9, 10, 11, 12, 13])?, 5);
         assert_eq!(buf.data(), &[9, 10, 11, 12, 13]);
 
-        buf.write(&[14, 15, 16, 17, 18, 19, 20, 21, 22]).unwrap();
+        assert_eq!(buf.write(&[14, 15, 16, 17, 18, 19, 20, 21, 22])?, 9);
         assert_eq!(buf.data(), &[18, 19, 20, 21, 22]);
+        Ok(())
     }
 }

src/agent/onefuzz/src/libfuzzer.rs

@@ -284,6 +284,10 @@ mod tests {
             .expect("no captures");
 
         assert_eq!(parsed.iters(), 2097152);
-        assert_eq!(parsed.execs_sec(), 699050.0_f64);
+
+        let expected: f64 = 699050.0;
+        let execs_sec = parsed.execs_sec();
+        assert!(execs_sec.is_finite());
+        assert!((execs_sec - expected).abs() < f64::EPSILON);
     }
 }