ExternalVendorCode/onefuzz
1
0
Fork 0
mirror of https://github.com/microsoft/onefuzz.git synced 2025-06-17 04:18:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

handle exception related to manually deleted scalesets (#672)

Browse Source 
If a user manually deletes a scaleset managed by OneFuzz, then `get_vmss_size` returns None.

When this happens, `Scaleset.shutdown` generates an exception from the `logging.info` call on line 573.

This PR handles this edge condition.
This commit is contained in:
bmc-msft
2021-03-15 10:18:59 -04:00
committed by GitHub
parent 9ee114ff71
commit a3fdc74c53
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/api-service/__app__/onefuzzlib/workers/scalesets.py
View File

@ -570,6 +570,15 @@ class Scaleset(BASE_SCALESET, ORMMixin):
def shutdown(self) -> None: def shutdown(self) -> None:
size = get_vmss_size(self.scaleset_id) size = get_vmss_size(self.scaleset_id)
if size is None:
logging.info(
SCALESET_LOG_PREFIX
+ "scaleset shutdown: scaleset already deleted - scaleset_id:%s",
self.scaleset_id,
)
self.halt()
return
logging.info( logging.info(
SCALESET_LOG_PREFIX + "scaleset shutdown: scaleset_id:%s size:%d", SCALESET_LOG_PREFIX + "scaleset shutdown: scaleset_id:%s size:%d",
self.scaleset_id, self.scaleset_id,
@ -578,7 +587,7 @@ class Scaleset(BASE_SCALESET, ORMMixin):
nodes = Node.search_states(scaleset_id=self.scaleset_id) nodes = Node.search_states(scaleset_id=self.scaleset_id)
for node in nodes: for node in nodes:
node.set_shutdown() node.set_shutdown()
if size is None or size == 0: if size == 0:
self.halt() self.halt()
def halt(self) -> None: def halt(self) -> None: