ExternalVendorCode/onefuzz
1
0
Fork 0
mirror of https://github.com/microsoft/onefuzz.git synced 2025-06-15 11:28:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

mark task as failued if ADO notification fails (#77)

Browse Source
This commit is contained in:
bmc-msft
2020-10-01 22:00:08 -04:00
committed by GitHub
parent 4ce9060dd0
commit 8b6ea9f66b
2 changed files with 29 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/api-service/__app__/onefuzzlib/notifications/ado.py
View File

@ -19,8 +19,10 @@ from azure.devops.v6_0.work_item_tracking.work_item_tracking_client import (
WorkItemTrackingClient, WorkItemTrackingClient,
) )
from memoization import cached from memoization import cached
from onefuzztypes.models import ADOTemplate, Report from onefuzztypes.enums import ErrorCode, TaskState
from onefuzztypes.models import ADOTemplate, Error, Report
from ..tasks.main import Task
from .common import Render from .common import Render
@ -194,13 +196,36 @@ class ADO:
self.create_new() self.create_new()
def fail_task(report: Report, error: Exception) -> None:
logging.error(
"ADO report failed: job_id:%s task_id:%s err:%s",
report.job_id,
report.task_id,
error,
)
task = Task.get(report.job_id, report.task_id)
if task:
task.error = Error(code=ErrorCode.NOTIFICATION_FAILURE, errors=[str(error)])
task.state = TaskState.stopping
task.save()
def notify_ado( def notify_ado(
config: ADOTemplate, container: str, filename: str, report: Report config: ADOTemplate, container: str, filename: str, report: Report
) -> None: ) -> None:
logging.info(
"notify ado: job_id:%s task_id:%s container:%s filename:%s",
report.job_id,
report.task_id,
container,
filename,
)
try: try:
ado = ADO(container, filename, config, report) ado = ADO(container, filename, config, report)
ado.process() ado.process()
except AzureDevOpsServiceError as err: except AzureDevOpsServiceError as err:
logging.error("ADO report failed: %s", err) fail_task(report, err)
except ValueError as err: except ValueError as err:
logging.error("ADO report value error: %s", err) fail_task(report, err)

1
src/pytypes/onefuzztypes/enums.py
View File

@ -227,6 +227,7 @@ class ErrorCode(Enum):
UNABLE_TO_FIND = 467 UNABLE_TO_FIND = 467
TASK_FAILED = 468 TASK_FAILED = 468
INVALID_NODE = 469 INVALID_NODE = 469
NOTIFICATION_FAILURE = 470
class HeartbeatType(Enum): class HeartbeatType(Enum):