ExternalVendorCode/onefuzz
1
0
Fork 0
mirror of https://github.com/microsoft/onefuzz.git synced 2025-06-16 11:58:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

reduce how often list_containers is called (#196)

Browse Source
This commit is contained in:
bmc-msft
2020-10-23 09:43:45 -04:00
committed by GitHub
parent b675ee75df
commit 8a62830f2b
5 changed files with 47 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/api-service/__app__/onefuzzlib/tasks/config.py
View File

@ -11,7 +11,7 @@ from uuid import UUID
from onefuzztypes.enums import Compare, ContainerPermission, ContainerType, TaskFeature
from onefuzztypes.models import TaskConfig, TaskDefinition, TaskUnitConfig
from ..azure.containers import blob_exists, get_container_sas_url, get_containers
from ..azure.containers import blob_exists, container_exists, get_container_sas_url
from ..azure.creds import get_fuzz_storage, get_instance_url
from ..azure.queue import get_queue_sas
from .defs import TASK_DEFINITIONS
@ -58,12 +58,14 @@ def check_container(
def check_containers(definition: TaskDefinition, config: TaskConfig) -> None:
all_containers = set(get_containers().keys())
checked = set()
containers: Dict[ContainerType, List[str]] = {}
for container in config.containers:
if container.name not in all_containers:
raise TaskConfigError("missing container: %s" % container.name)
if container.name not in checked:
if not container_exists(container.name):
raise TaskConfigError("missing container: %s" % container.name)
checked.add(container.name)
if container.type not in containers:
containers[container.type] = []