ExternalVendorCode/onefuzz
1
0
Fork 0
mirror of https://github.com/microsoft/onefuzz.git synced 2025-06-17 12:28:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Breaking Change] Deploy with scriban only turned on (#2809)

Browse Source 
* Deploy with scriban only turned on

* Improve description
This commit is contained in:
Teo Voinea
2023-02-14 08:31:39 -05:00
committed by GitHub
parent 0bc22a8073
commit 307526fb64
5 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/ApiService/ApiService/Functions/ValidateScriban.cs
View File

@ -139,6 +139,7 @@ public class ValidateScriban {
reportContainer,
reportFileName,
report,
_log,
task,
job,
targetUrl,

2
src/ApiService/ApiService/onefuzzlib/notifications/Ado.cs
View File

@ -69,7 +69,7 @@ public class Ado : NotificationsBase, IAdo {
private readonly Uri _instanceUrl;
private readonly ILogTracer _logTracer;
public static async Async.Task<AdoConnector> AdoConnectorCreator(IOnefuzzContext context, Container container, string filename, AdoTemplate config, Report report, ILogTracer logTracer, Renderer? renderer = null) {
renderer ??= await Renderer.ConstructRenderer(context, container, filename, report);
renderer ??= await Renderer.ConstructRenderer(context, container, filename, report, logTracer);
var instanceUrl = context.Creds.GetInstanceUrl();
var project = await renderer.Render(config.Project, instanceUrl);

2
src/ApiService/ApiService/onefuzzlib/notifications/GithubIssues.cs
View File

@ -31,7 +31,7 @@ public class GithubIssues : NotificationsBase, IGithubIssues {
}
private async Async.Task Process(GithubIssuesTemplate config, Container container, string filename, Report report) {
var renderer = await Renderer.ConstructRenderer(_context, container, filename, report);
var renderer = await Renderer.ConstructRenderer(_context, container, filename, report, _logTracer);
var handler = await GithubConnnector.GithubConnnectorCreator(config, container, filename, renderer, _context.Creds.GetInstanceUrl(), _context, _logTracer);
await handler.Process();
}

6
src/ApiService/ApiService/onefuzzlib/notifications/NotificationsBase.cs
View File

@ -48,6 +48,7 @@ public abstract class NotificationsBase {
Container container,
string filename,
Report report,
ILogTracer log,
Task? task = null,
Job? job = null,
Uri? targetUrl = null,
@ -76,7 +77,10 @@ public abstract class NotificationsBase {
}
await context.ConfigurationRefresher.TryRefreshAsync().IgnoreResult();
var scribanOnly = scribanOnlyOverride ?? await context.FeatureManagerSnapshot.IsEnabledAsync(FeatureFlagConstants.EnableScribanOnly);
var scribanOnlyFeatureFlag = await context.FeatureManagerSnapshot.IsEnabledAsync(FeatureFlagConstants.EnableScribanOnly);
log.Info($"ScribanOnlyFeatureFlag: {scribanOnlyFeatureFlag}");
var scribanOnly = scribanOnlyOverride ?? scribanOnlyFeatureFlag;
return new Renderer(
container,

13
src/deployment/bicep-templates/feature-flags.bicep
View File

@ -11,4 +11,17 @@ resource featureFlags 'Microsoft.AppConfiguration/configurationStores@2022-05-01
}
}
resource configStoreFeatureflag 'Microsoft.AppConfiguration/configurationStores/keyValues@2021-10-01-preview' = {
parent: featureFlags
name: '.appconfig.featureflag~2FEnableScribanOnly'
properties: {
value: string({
id: 'EnableScribanOnly'
description: 'Render notification templates with scriban only'
enabled: true
})
contentType: 'application/vnd.microsoft.appconfig.ff+json;charset=utf-8'
}
}
output AppConfigEndpoint string = 'https://${appConfigName}.azconfig.io'