From 29c7cfbd5dc51416aae1215ed48ef0f21c52f42f Mon Sep 17 00:00:00 2001 From: bmc-msft <41130664+bmc-msft@users.noreply.github.com> Date: Mon, 4 Jan 2021 15:28:57 -0500 Subject: [PATCH] filter out deleted nodes as to prevent them from being saved later (#391) In `Scaleset.cleanup_nodes`, nodes that are no longer part of the scaleset should get deleted. Without filtering the list, the nodes could get re-saved to the Node table later on. --- src/api-service/__app__/onefuzzlib/pools.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/api-service/__app__/onefuzzlib/pools.py b/src/api-service/__app__/onefuzzlib/pools.py index 4ddf818be..3fb6cfb0b 100644 --- a/src/api-service/__app__/onefuzzlib/pools.py +++ b/src/api-service/__app__/onefuzzlib/pools.py @@ -790,6 +790,7 @@ class Scaleset(BASE_SCALESET, ORMMixin): "no longer in scaleset: %s:%s", self.scaleset_id, node.machine_id ) node.delete() + nodes = [x for x in nodes if x.machine_id in azure_nodes] nodes_to_reset = [x for x in nodes if x.state in NodeState.ready_for_reset()]