From 0bc22a8073e3ff11fc197ea44774722a0136a50e Mon Sep 17 00:00:00 2001 From: Noah McGregor Harper <74685766+nharper285@users.noreply.github.com> Date: Fri, 10 Feb 2023 23:11:35 +0000 Subject: [PATCH] Fixing bug in registration.py for creating CLI SP's. (#2828) * Fixing bug in registration.py for creating CLI SP's. * Formatting. --- src/deployment/deploylib/registration.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/deployment/deploylib/registration.py b/src/deployment/deploylib/registration.py index 05f04053c..aa77d68d0 100644 --- a/src/deployment/deploylib/registration.py +++ b/src/deployment/deploylib/registration.py @@ -244,7 +244,6 @@ def create_application_registration( app = get_application( display_name=onefuzz_instance_name, subscription_id=subscription_id ) - if not app: raise Exception("onefuzz app registration not found") @@ -338,7 +337,9 @@ def create_application_registration( registered_app_id = registered_app["appId"] app_id = app["appId"] - authorize_and_assign_role(app_id, registered_app_id, approle, subscription_id) + authorize_and_assign_role( + UUID(app_id), UUID(registered_app_id), approle, subscription_id + ) return registered_app @@ -434,7 +435,6 @@ def get_application( filters.append("displayName eq '%s'" % display_name) filter_str = " and ".join(filters) - apps = query_microsoft_graph( method="GET", resource="applications",