From 06fb0d3fd0331ae2d1939723dc5831e384f00aff Mon Sep 17 00:00:00 2001
From: Kanan B <32438208+kananb@users.noreply.github.com>
Date: Wed, 19 Jul 2023 15:53:42 -0700
Subject: [PATCH] Kanan/test template fix (#3308)

* Fix test_template logic

* Rewrite test_template logic to make it's intention more clear
---
 src/cli/onefuzz/debug.py | 33 +++++++++++++++------------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/src/cli/onefuzz/debug.py b/src/cli/onefuzz/debug.py
index 9ddd06e68..dc93f49f8 100644
--- a/src/cli/onefuzz/debug.py
+++ b/src/cli/onefuzz/debug.py
@@ -822,29 +822,26 @@ class DebugNotification(Command):
     ) -> responses.NotificationTestResponse:
         """Test a notification template"""
 
-        if task_id is None and report is None:
-            raise Exception("must specify either task_id or report")
-
-        endpoint = Endpoint(self.onefuzz)
         if task_id is not None:
             task = self.onefuzz.tasks.get(task_id)
-            input_blob_ref = BlobRef(
-                account="dummy-storage-account",
-                container="test-notification-crashes",
-                name="fake-crash-sample",
-            )
-
-        if report is None:
-            report = self._create_report(
-                task.job_id, task.task_id, "fake_target.exe", input_blob_ref
-            )
-
-        if task is not None:
-            report.task_id = task.task_id
-            report.job_id = task.job_id
+            if report is None:
+                input_blob_ref = BlobRef(
+                    account="dummy-storage-account",
+                    container="test-notification-crashes",
+                    name="fake-crash-sample",
+                )
+                report = self._create_report(
+                    task.job_id, task.task_id, "fake_target.exe", input_blob_ref
+                )
+            else:
+                report.task_id = task.task_id
+                report.job_id = task.job_id
+        elif report is None:
+            raise Exception("must specify either task_id or report")
 
         report.report_url = "https://dummy-container.blob.core.windows.net/dummy-reports/dummy-report.json"
 
+        endpoint = Endpoint(self.onefuzz)
         return endpoint._req_model(
             "POST",
             responses.NotificationTestResponse,