ExternalVendorCode/heads
1
0
Fork 0
mirror of https://github.com/linuxboot/heads.git synced 2024-12-19 21:17:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

initrd/bin/change-time: Label parameters of get_date

Browse Source 
Use local named variables instead of $1-$4 throughout the function.
This makes the implementation clearer and documents the usage.

Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm>
This commit is contained in:
Jonathon Hall 2024-08-06 08:49:30 -04:00
parent f4ce047167
commit 16f0793648
No known key found for this signature in database
GPG Key ID: 1E9C3CA91AE25114
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
initrd/bin/change-time
View File

@ -8,22 +8,27 @@ echo -e -n "You need to set the time according to the UTC/GMT timezone please ch
get_date () {
echo -e -n "Please insert $1 (between $2-$3) (Enter key to accept $2)\n"
read -n $4 value
local field_name min max digits
field_name="$1"
min="$2"
max="$3"
digits="$4"
echo -e -n "Please insert $field_name (between $min-$max) (Enter key to accept $min)\n"
read -n $digits value
echo -e "\n"
#if enter
if [[ $value = "" ]]; then
value=$2
value=$min
fi
#must be a $4 digits number between $2 and $3
while [[ ! $value =~ ^[0-9]{$4} ]] || [[ ${value#0} -lt $2 ]] || [[ ${value#0} -gt $3 ]];
while [[ ! $value =~ ^[0-9]{$digits} ]] || [[ ${value#0} -lt $min ]] || [[ ${value#0} -gt $max ]];
do
echo -e -n "$1 is wrong: you entered "$value". Please try again, it must be $4 digits number between $2 and $3 (press Enter to accept $2) \n"
read -n $4 value
echo -e -n "$field_name is wrong: you entered \"$value\". Please try again, it must be $digits digits number between $min and $max (press Enter to accept $min) \n"
read -n $digits value
echo -e "\n"
if [[ $value = "" ]]; then
value=$2
value=$min
fi
done
}