ExternalVendorCode/go-attestation
1
0
Fork 0
mirror of https://github.com/google/go-attestation.git synced 2024-12-18 20:47:57 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add critical bool arg to MarshalSubjectAltName to allow SANs to be critical (#367)

Browse Source
This commit is contained in:
Liam Murphy 2024-03-27 10:34:46 +11:00 committed by GitHub
parent e6ab626979
commit 5b3763098f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
x509/x509ext.go
View File

@ -149,8 +149,9 @@ func forEachSAN(extension []byte, callback func(ext asn1.RawValue) error) error
return nil return nil
} }
// MarshalSubjectAltName converts a SubjectAltName struct into a pkix.Extension. // MarshalSubjectAltName converts a SubjectAltName struct into a pkix.Extension,
func MarshalSubjectAltName(san *SubjectAltName) (pkix.Extension, error) { // allowing callers to specify if the extension is critical.
func MarshalSubjectAltName(san *SubjectAltName, critical bool) (pkix.Extension, error) {
var generalNames []asn1.RawValue var generalNames []asn1.RawValue
for _, permID := range san.PermanentIdentifiers { for _, permID := range san.PermanentIdentifiers {
val, err := marshalOtherName(oidPermanentIdentifier, permID) val, err := marshalOtherName(oidPermanentIdentifier, permID)
@ -171,7 +172,8 @@ func MarshalSubjectAltName(san *SubjectAltName) (pkix.Extension, error) {
return pkix.Extension{}, err return pkix.Extension{}, err
} }
return pkix.Extension{ return pkix.Extension{
Id: oid.SubjectAltName, Id: oid.SubjectAltName,
Value: val, Critical: critical,
Value: val,
}, nil }, nil
} }