ExternalVendorCode/gns3-web-ui
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-web-ui.git synced 2024-12-29 17:28:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixes after review

Browse Source
This commit is contained in:
Piotr Pekala 2019-06-04 06:24:46 -07:00
parent 2a56441ce9
commit ceafe49ebd
5 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/app.module.ts
View File

@ -184,8 +184,8 @@ import { AdbutlerComponent } from './components/adbutler/adbutler.component';
import { ConsoleService } from './services/settings/console.service'; import { ConsoleService } from './services/settings/console.service';
import { DefaultConsoleService } from './services/settings/default-console.service'; import { DefaultConsoleService } from './services/settings/default-console.service';
import { NodeCreatedLabelStylesFixer } from './components/project-map/helpers/node-created-label-styles-fixer'; import { NodeCreatedLabelStylesFixer } from './components/project-map/helpers/node-created-label-styles-fixer';
import { NonNegativeValidator } from './validators/NonNegativeValidator'; import { NonNegativeValidator } from './validators/non-negative-validator';
import { RotationValidator } from './validators/RotationValidator'; import { RotationValidator } from './validators/rotation-validator';
if (environment.production) { if (environment.production) {
Raven.config('https://b2b1cfd9b043491eb6b566fd8acee358@sentry.io/842726', { Raven.config('https://b2b1cfd9b043491eb6b566fd8acee358@sentry.io/842726', {

5
src/app/components/project-map/drawings-editors/style-editor/style-editor.component.ts
View File

@ -12,8 +12,8 @@ import { LineElement } from '../../../../cartography/models/drawings/line-elemen
import { RectElement } from '../../../../cartography/models/drawings/rect-element'; import { RectElement } from '../../../../cartography/models/drawings/rect-element';
import { FormGroup, FormBuilder, FormControl, Validators } from '@angular/forms'; import { FormGroup, FormBuilder, FormControl, Validators } from '@angular/forms';
import { ToasterService } from '../../../../services/toaster.service'; import { ToasterService } from '../../../../services/toaster.service';
import { NonNegativeValidator } from '../../../../validators/NonNegativeValidator'; import { NonNegativeValidator } from '../../../../validators/non-negative-validator';
import { RotationValidator } from '../../../../validators/RotationValidator'; import { RotationValidator } from '../../../../validators/rotation-validator';
@Component({ @Component({
selector: 'app-style-editor', selector: 'app-style-editor',
@ -58,6 +58,7 @@ export class StyleEditorDialogComponent implements OnInit {
this.element.stroke_width = this.drawing.element.stroke_width; this.element.stroke_width = this.drawing.element.stroke_width;
} }
if (this.element.stroke_width === undefined) this.element.stroke_width = 0;
this.formGroup.controls['borderWidth'].setValue(this.element.stroke_width); this.formGroup.controls['borderWidth'].setValue(this.element.stroke_width);
this.formGroup.controls['rotation'].setValue(this.drawing.rotation); this.formGroup.controls['rotation'].setValue(this.drawing.rotation);
} }

2
src/app/components/project-map/drawings-editors/text-editor/text-editor.component.ts
View File

@ -10,7 +10,7 @@ import { DrawingsDataSource } from '../../../../cartography/datasources/drawings
import { TextElement } from '../../../../cartography/models/drawings/text-element'; import { TextElement } from '../../../../cartography/models/drawings/text-element';
import { FormBuilder, FormGroup, FormControl, Validators } from '@angular/forms'; import { FormBuilder, FormGroup, FormControl, Validators } from '@angular/forms';
import { ToasterService } from '../../../../services/toaster.service'; import { ToasterService } from '../../../../services/toaster.service';
import { RotationValidator } from '../../../../validators/RotationValidator'; import { RotationValidator } from '../../../../validators/rotation-validator';
@Component({ @Component({
selector: 'app-text-editor', selector: 'app-text-editor',

0
src/app/validators/NonNegativeValidator.ts → src/app/validators/non-negative-validator.ts
View File

0
src/app/validators/RotationValidator.ts → src/app/validators/rotation-validator.ts
View File