From 6dfe28ec8f5d481bcdecfe78507b0143e63f3940 Mon Sep 17 00:00:00 2001
From: grossmj <grossmj@gns3.net>
Date: Mon, 27 Nov 2023 11:00:22 +1000
Subject: [PATCH] Fix typos

---
 src/app/components/login/login.component.html          |  2 +-
 src/app/components/login/login.component.ts            | 10 +++++-----
 .../context-console-menu.component.ts                  |  3 +--
 .../console-device-action-browser.component.ts         | 10 ++++++++--
 .../project-map/nodes-menu/nodes-menu.component.ts     |  2 +-
 src/app/filters/authImageFilter.ts                     |  2 +-
 src/app/services/mapsettings.service.ts                |  2 +-
 7 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/src/app/components/login/login.component.html b/src/app/components/login/login.component.html
index 43035773..66c4d005 100644
--- a/src/app/components/login/login.component.html
+++ b/src/app/components/login/login.component.html
@@ -24,7 +24,7 @@
       </form>
       <mat-checkbox
         [disabled]="!isRememberMe"
-        [checked]="isRememberMeCheked"
+        [checked]="isRememberMeChecked"
         class="margin-left"
         color="primary"
         (change)="rememberMe($event)"
diff --git a/src/app/components/login/login.component.ts b/src/app/components/login/login.component.ts
index 7f012ee3..efb62ece 100644
--- a/src/app/components/login/login.component.ts
+++ b/src/app/components/login/login.component.ts
@@ -24,7 +24,7 @@ export class LoginComponent implements OnInit, DoCheck {
   public loginError: boolean = false;
   public returnUrl: string = '';
   public isRememberMe: boolean = false;
-  public isRememberMeCheked: boolean = false;
+  public isRememberMeChecked: boolean = false;
 
   loginForm = new UntypedFormGroup({
     username: new UntypedFormControl('', [Validators.required]),
@@ -65,7 +65,7 @@ export class LoginComponent implements OnInit, DoCheck {
     if (getCurrentUser && getCurrentUser.isRememberMe) {
       this.loginForm.get('username').setValue(getCurrentUser.username);
       this.loginForm.get('password').setValue(getCurrentUser.password);
-      this.isRememberMeCheked = getCurrentUser.isRememberMe;
+      this.isRememberMeChecked = getCurrentUser.isRememberMe;
     }
   }
 
@@ -101,13 +101,13 @@ export class LoginComponent implements OnInit, DoCheck {
 
   rememberMe(ev) {
     if (ev.checked) {
-      let curren_user = {
+      let current_user = {
         username: this.loginForm.get('username').value,
         password: this.loginForm.get('password').value,
         isRememberMe: ev.checked,
       };
-      this.isRememberMeCheked = ev.checked;
-      localStorage.setItem(`isRememberMe`, JSON.stringify(curren_user));
+      this.isRememberMeChecked = ev.checked;
+      localStorage.setItem(`isRememberMe`, JSON.stringify(current_user));
     } else {
       localStorage.removeItem(`isRememberMe`);
       this.loginForm.reset();
diff --git a/src/app/components/project-map/context-console-menu/context-console-menu.component.ts b/src/app/components/project-map/context-console-menu/context-console-menu.component.ts
index ce0ca024..7ebd3ae8 100644
--- a/src/app/components/project-map/context-console-menu/context-console-menu.component.ts
+++ b/src/app/components/project-map/context-console-menu/context-console-menu.component.ts
@@ -64,7 +64,7 @@ export class ContextConsoleMenuComponent implements OnInit {
 
   public openMenu(node: Node, top: number, left: number) {
     this.node = node;
-    let action = this.mapSettingsService.getConsoleContextManuAction();
+    let action = this.mapSettingsService.getConsoleContextMenuAction();
     if (action) {
       if (action === 'web console') {
         this.openWebConsole();
@@ -97,7 +97,6 @@ export class ContextConsoleMenuComponent implements OnInit {
       this.componentBrowserRef = this.container.createComponent(factory);
       this.componentBrowserRef.instance.controller = this.controller;
       this.componentBrowserRef.instance.node = this.node;
-
       this.componentBrowserRef.instance.openConsole();
     }
   }
diff --git a/src/app/components/project-map/context-menu/actions/console-device-action-browser/console-device-action-browser.component.ts b/src/app/components/project-map/context-menu/actions/console-device-action-browser/console-device-action-browser.component.ts
index 7fe0b8ed..f95540c6 100644
--- a/src/app/components/project-map/context-menu/actions/console-device-action-browser/console-device-action-browser.component.ts
+++ b/src/app/components/project-map/context-menu/actions/console-device-action-browser/console-device-action-browser.component.ts
@@ -1,7 +1,7 @@
 import { Component, Input } from '@angular/core';
 import { DeviceDetectorService } from 'ngx-device-detector';
 import { Node } from '../../../../../cartography/models/node';
-import{ Controller } from '../../../../../models/controller';
+import { Controller } from '../../../../../models/controller';
 import { NodeService } from '../../../../../services/node.service';
 import { ToasterService } from '../../../../../services/toaster.service';
 
@@ -13,7 +13,11 @@ export class ConsoleDeviceActionBrowserComponent {
   @Input() controller:Controller ;
   @Input() node: Node;
 
-  constructor(private toasterService: ToasterService, private nodeService: NodeService, private deviceService: DeviceDetectorService) {}
+  constructor(
+  private toasterService: ToasterService,
+  private nodeService: NodeService,
+  private deviceService: DeviceDetectorService
+  ) {}
 
   openConsole() {
     this.nodeService.getNode(this.controller, this.node).subscribe((node: Node) => {
@@ -36,6 +40,7 @@ export class ConsoleDeviceActionBrowserComponent {
 
       if (!iframe) {
           iframe = this.createHiddenIframe(document.body, "about:blank");
+          //setTimeout(() => { iframe.parentNode.removeChild(iframe); }, 0);
       }
 
       try {
@@ -76,6 +81,7 @@ export class ConsoleDeviceActionBrowserComponent {
           this.toasterService.error('Supported console types are: telnet, vnc, spice and spice+agent.');
         }
 
+        console.log("Opening external console using " + device.browser + " browser");
         if (device.browser === "Firefox") {
             // Use a hidden iframe otherwise Firefox will disconnect
             // from the GNS3 controller websocket if we use location.assign()
diff --git a/src/app/components/project-map/nodes-menu/nodes-menu.component.ts b/src/app/components/project-map/nodes-menu/nodes-menu.component.ts
index 111b4f3a..d9d871ec 100644
--- a/src/app/components/project-map/nodes-menu/nodes-menu.component.ts
+++ b/src/app/components/project-map/nodes-menu/nodes-menu.component.ts
@@ -3,7 +3,7 @@ import { MatDialog } from '@angular/material/dialog';
 import { ElectronService } from 'ngx-electron';
 import { NodesDataSource } from '../../../cartography/datasources/nodes-datasource';
 import { Project } from '../../../models/project';
-import{ Controller } from '../../../models/controller';
+import { Controller } from '../../../models/controller';
 import { MapSettingsService } from '../../../services/mapsettings.service';
 import { NodeService } from '../../../services/node.service';
 import { NodeConsoleService } from '../../../services/nodeConsole.service';
diff --git a/src/app/filters/authImageFilter.ts b/src/app/filters/authImageFilter.ts
index 0b7833ac..c70dd5d6 100644
--- a/src/app/filters/authImageFilter.ts
+++ b/src/app/filters/authImageFilter.ts
@@ -1,6 +1,6 @@
 import { Pipe, PipeTransform } from '@angular/core';
 import { Console } from 'console';
-import{ Controller } from '../models/controller';
+import { Controller } from '../models/controller';
 import { HttpController } from '../services/http-controller.service';
 import { DomSanitizer } from '@angular/platform-browser';
 import { environment } from 'environments/environment';
diff --git a/src/app/services/mapsettings.service.ts b/src/app/services/mapsettings.service.ts
index 88d00ae2..7abf7eb6 100644
--- a/src/app/services/mapsettings.service.ts
+++ b/src/app/services/mapsettings.service.ts
@@ -60,7 +60,7 @@ export class MapSettingsService {
     localStorage.setItem('consoleContextMenu', action);
   }
 
-  getConsoleContextManuAction(): string {
+  getConsoleContextMenuAction(): string {
     return localStorage.getItem('consoleContextMenu');
   }