From aa5988788d21f53facf47d78003bd90b2abdbd78 Mon Sep 17 00:00:00 2001 From: Julien Duponchelle Date: Wed, 15 Jun 2016 18:22:11 +0200 Subject: [PATCH] Strip user from compute in topology and return project filename --- gns3server/controller/compute.py | 3 +-- gns3server/controller/project.py | 11 +++++++---- gns3server/schemas/project.py | 5 +++++ tests/controller/test_compute.py | 1 - tests/controller/test_project.py | 2 +- 5 files changed, 14 insertions(+), 8 deletions(-) diff --git a/gns3server/controller/compute.py b/gns3server/controller/compute.py index 80071f2b..94960b41 100644 --- a/gns3server/controller/compute.py +++ b/gns3server/controller/compute.py @@ -238,8 +238,7 @@ class Compute: "name": self._name, "protocol": self._protocol, "host": self._host, - "port": self._port, - "user": self._user + "port": self._port } return { "compute_id": self._id, diff --git a/gns3server/controller/project.py b/gns3server/controller/project.py index aafca8d3..b7df4d69 100644 --- a/gns3server/controller/project.py +++ b/gns3server/controller/project.py @@ -322,12 +322,14 @@ class Project: raise aiohttp.web.HTTPInternalServerError(text="Could not create project directory: {}".format(e)) return path - def _topology_file(self): + def _filename(self): if self.name is None: - filename = "untitled.gns3" + return "untitled.gns3" else: - filename = self.name + ".gns3" - return os.path.join(self.path, filename) + return self.name + ".gns3" + + def _topology_file(self): + return os.path.join(self.path, self._filename()) @asyncio.coroutine def open(self): @@ -371,5 +373,6 @@ class Project: "name": self._name, "project_id": self._id, "path": self._path, + "filename": self._filename(), "status": self._status } diff --git a/gns3server/schemas/project.py b/gns3server/schemas/project.py index 7e80ff41..4b81f516 100644 --- a/gns3server/schemas/project.py +++ b/gns3server/schemas/project.py @@ -82,6 +82,11 @@ PROJECT_OBJECT_SCHEMA = { "type": ["string", "null"], "minLength": 1 }, + "filename": { + "description": "Project filename", + "type": ["string", "null"], + "minLength": 1 + }, "status": { "description": "Project status Read only", "enum": ["opened", "closed"] diff --git a/tests/controller/test_compute.py b/tests/controller/test_compute.py index 7982fe8e..3ea75e44 100644 --- a/tests/controller/test_compute.py +++ b/tests/controller/test_compute.py @@ -211,7 +211,6 @@ def test_json(compute): "protocol": "https", "host": "example.com", "port": 84, - "user": "test", } diff --git a/tests/controller/test_project.py b/tests/controller/test_project.py index 1eabe5fc..567a356a 100644 --- a/tests/controller/test_project.py +++ b/tests/controller/test_project.py @@ -43,7 +43,7 @@ def test_affect_uuid(): def test_json(tmpdir): p = Project() - assert p.__json__() == {"name": p.name, "project_id": p.id, "path": p.path, "status": "opened"} + assert p.__json__() == {"name": p.name, "project_id": p.id, "path": p.path, "status": "opened", "filename": "untitled.gns3"} def test_path(tmpdir):