Support for sendings settings for the GNS3VM from the GUI

Ref https://github.com/GNS3/gns3-gui/issues/1441

gns3server/handlers/api/controller/gns3_vm_handler.py

@@ -17,8 +17,9 @@
 
 from aiohttp.web import HTTPConflict
 from gns3server.web.route import Route
-from gns3server.controller.vmware_gns3_vm import VMwareGNS3VM
-from gns3server.controller.virtualbox_gns3_vm import VirtualBoxGNS3VM
+from gns3server.controller import Controller
+from gns3server.schemas.gns3vm import GNS3VM_SETTINGS_SCHEMA
+
 
 import logging
 log = logging.getLogger(__name__)
@@ -28,7 +29,18 @@ class GNS3VMHandler:
     """API entry points for GNS3 VM management."""
 
     @Route.get(
-        r"/gns3vm/{engine}/vms",
+        r"/gns3vm/engines",
+        description="Return the list of engines supported for the GNS3VM",
+        status_codes={
+            200: "OK"
+        })
+    def list_engines(request, response):
+
+        gns3_vm = Controller().instance().gns3vm
+        response.json(gns3_vm.engine_list())
+
+    @Route.get(
+        r"/gns3vm/engines/{engine}/vms",
         parameters={
             "engine": "Virtualization engine name"
         },
@@ -39,14 +51,7 @@ class GNS3VMHandler:
         description="Get all the available VMs for a specific virtualization engine")
     def get_vms(request, response):
 
-        engine = request.match_info["engine"]
-        if engine == "vmware":
-            engine_instance = VMwareGNS3VM.instance()
-        elif engine == "virtualbox":
-            engine_instance = VirtualBoxGNS3VM.instance()
-        else:
-            raise HTTPConflict(text="Unknown engine: '{}'".format(engine))
-        vms = yield from engine_instance.list()
+        vms = yield from Controller.instance().gns3vm.list(request.match_info["engine"])
         response.json(vms)
 
     @Route.get(
@@ -54,51 +59,22 @@ class GNS3VMHandler:
         description="Get GNS3 VM settings",
         status_codes={
             200: "GNS3 VM settings returned"
-        })
+        },
+        output_schema=GNS3VM_SETTINGS_SCHEMA)
     def show(request, response):
-
-        gns3_vm = VMwareGNS3VM.instance()
-        response.json(gns3_vm)
+        response.json(Controller.instance().gns3vm)
 
     @Route.put(
         r"/gns3vm",
         description="Update GNS3 VM settings",
-        #input=GNS3VM_UPDATE_SCHEMA,  # TODO: validate settings
+        input_schema=GNS3VM_SETTINGS_SCHEMA,
+        output_schema=GNS3VM_SETTINGS_SCHEMA,
         status_codes={
-            200: "GNS3 VM updated"
+            201: "GNS3 VM updated"
         })
     def update(request, response):
 
-        gns3_vm = VMwareGNS3VM.instance()
-        for name, value in request.json.items():
-            if hasattr(gns3_vm, name) and getattr(gns3_vm, name) != value:
-                setattr(gns3_vm, name, value)
-        gns3_vm.save()
+        gns3_vm = Controller().instance().gns3vm
+        gns3_vm.settings = request.json
         response.json(gns3_vm)
-
-    @Route.post(
-        r"/gns3vm/start",
-        status_codes={
-            200: "Instance started",
-            400: "Invalid request",
-        },
-        description="Start the GNS3 VM"
-    )
-    def start(request, response):
-
-        gns3_vm = VMwareGNS3VM.instance()
-        yield from gns3_vm.start()
-        response.json(gns3_vm)
-
-    @Route.post(
-        r"/gns3vm/stop",
-        status_codes={
-            204: "Instance stopped",
-            400: "Invalid request",
-        },
-        description="Stop the GNS3 VM")
-    def stop(request, response):
-
-        gns3_vm = VMwareGNS3VM.instance()
-        yield from gns3_vm.stop()
-        response.set_status(204)
+        response.set_status(201)