ExternalVendorCode/gns3-server
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-server.git synced 2025-06-17 14:58:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improvement to validate HTTP authentication config. Ref #1662

Browse Source
This commit is contained in:
grossmj
2019-10-09 15:56:20 +08:00
parent 5a3f8b9a9b
commit 1b845225b2
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gns3server/web/route.py
View File

@ -111,14 +111,14 @@ class Route(object):
user = server_config.get("user", "").strip()
password = server_config.get("password", "").strip()
if not user:
return
if "AUTHORIZATION" in request.headers:
if user and "AUTHORIZATION" in request.headers:
if request.headers["AUTHORIZATION"] == aiohttp.helpers.BasicAuth(user, password, "utf-8").encode():
return None
log.error("Invalid authentication. Username should be {}".format(user))
if not user:
log.error("HTTP authentication is enabled but no username is configured")
else:
log.error("Invalid authentication for username '{}'".format(user))
response = Response(request=request, route=route)
response.set_status(401)