ExternalVendorCode/gns3-registry
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-registry.git synced 2025-02-20 17:22:48 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #291 from adosztal/master

Browse Source 
PR template
This commit is contained in:
Jeremy Grossmann 2017-12-10 22:12:49 +00:00 committed by GitHub
commit fce5092310
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
PULL_REQUEST_TEMPLATE.md Normal file
View File

@ -0,0 +1,17 @@
Before submitting a pull request, please check the following.
---
When updating an **existing** appliance:
- [ ] The new version is on top.
- [ ] The filesnames in the "images" section are unique, to avoid appliances / version overwrinting each other.
- [ ] If you forked the repo, running check.py doesn't drop any errors for the updated file.
---
When creating a **new** appliance:
- It's tested locally, i.e.
- [ ] You dragged an instance into a project on your box, got it installed (if necessary), and did some basic network checks (ping, UI reachable, etc.).
- [ ] GNS3 VM can run it without any tweaks.
- [ ] You filled in as much info as possible (checks the schemas and other appliance files for some guidance).
- [ ] When adding a container: it builds on Docker Hub and can be pulled.
- [ ] The filesnames in the "images" section are unique (to avoid appliances and/or versions overwriting each other).
- [ ] If you forked the repo, running check.py doesn't drop any errors for the new file.
- [ ] *Optional: a symbol has been created for the new appliance.*