genode

mirror of https://github.com/genodelabs/genode.git synced 2024-12-20 22:23:16 +00:00

History

Norman Feske eba9c15746 Follow practices suggested by "Effective C++" The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465		2018-01-17 12:14:35 +01:00
..
contrib/generated	Move repositories to 'repos/' subdirectory	2014-05-14 16:08:00 +02:00
doc	base-okl4: remove unmaintained porting steps	2016-03-07 12:34:45 +01:00
etc	Add unified build directories to create_builddir	2017-01-13 13:05:44 +01:00
lib	Follow practices suggested by "Effective C++"	2018-01-17 12:14:35 +01:00
patches	okl4: declare read-write-lock as volatile	2014-11-20 16:39:16 +01:00
ports	okl4: apply patches in deterministic order	2017-08-30 12:41:43 +02:00
recipes/src/base-okl4	depot: update recipe hashes	2017-12-21 15:01:56 +01:00
run	run: use default Qemu memory size for x86	2017-05-31 13:16:19 +02:00
src	Follow practices suggested by "Effective C++"	2018-01-17 12:14:35 +01:00
tool	Move repositories to 'repos/' subdirectory	2014-05-14 16:08:00 +02:00
README	base-okl4: remove unmaintained porting steps	2016-03-07 12:34:45 +01:00

README

This repository contains the implementation of Genode for the OKL4
kernel version 2.1.  For further information, please refer to the
following website:

:[http://genode.org/documentation/articles/genode-on-okl4 - Bringing Genode to OKL4]:
  This article explains the OKL4-specific porting work.