mirror of
https://github.com/genodelabs/genode.git
synced 2025-02-06 02:59:54 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
154 lines
3.5 KiB
C++
154 lines
3.5 KiB
C++
/*
|
|
* \brief Pager support for OKL4
|
|
* \author Norman Feske
|
|
* \date 2009-03-31
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2009-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* Genode includes */
|
|
#include <base/log.h>
|
|
|
|
/* core includes */
|
|
#include <ipc_pager.h>
|
|
#include <pager.h>
|
|
#include <platform_thread.h>
|
|
|
|
/* base-internal includes */
|
|
#include <base/internal/native_thread.h>
|
|
#include <base/internal/native_utcb.h>
|
|
#include <base/internal/capability_space_tpl.h>
|
|
#include <base/internal/okl4.h>
|
|
|
|
static const bool verbose_page_fault = false;
|
|
static const bool verbose_exception = false;
|
|
|
|
|
|
using namespace Genode;
|
|
using namespace Okl4;
|
|
|
|
/**
|
|
* Print page-fault information in a human-readable form
|
|
*/
|
|
static inline void print_page_fault(L4_Word_t type, L4_Word_t addr, L4_Word_t ip,
|
|
unsigned long badge)
|
|
{
|
|
log("page (",
|
|
type & L4_Readable ? "r" : "-",
|
|
type & L4_Writable ? "w" : "-",
|
|
type & L4_eXecutable ? "x" : "-",
|
|
") fault at fault_addr=, ", Hex(addr), ", ip=", Hex(ip), ", from=", badge);
|
|
}
|
|
|
|
|
|
/**
|
|
* Return the global thread ID of the calling thread
|
|
*
|
|
* On OKL4 we cannot use 'L4_Myself()' to determine our own thread's
|
|
* identity. By convention, each thread stores its global ID in a
|
|
* defined entry of its UTCB.
|
|
*/
|
|
static inline Okl4::L4_ThreadId_t thread_get_my_global_id()
|
|
{
|
|
Okl4::L4_ThreadId_t myself;
|
|
myself.raw = Okl4::__L4_TCR_ThreadWord(UTCB_TCR_THREAD_WORD_MYSELF);
|
|
return myself;
|
|
}
|
|
|
|
|
|
/*************
|
|
** Mapping **
|
|
*************/
|
|
|
|
Mapping::Mapping(addr_t dst_addr, addr_t src_addr, Cache_attribute, bool,
|
|
unsigned l2size, bool rw, bool)
|
|
:
|
|
_fpage(L4_FpageLog2(dst_addr, l2size)),
|
|
/*
|
|
* OKL4 does not support write-combining as mapping attribute.
|
|
*/
|
|
_phys_desc(L4_PhysDesc(src_addr, 0))
|
|
{
|
|
L4_Set_Rights(&_fpage, rw ? L4_ReadWriteOnly : L4_ReadeXecOnly);
|
|
}
|
|
|
|
|
|
Mapping::Mapping() { }
|
|
|
|
|
|
/***************
|
|
** IPC pager **
|
|
***************/
|
|
|
|
void Ipc_pager::wait_for_fault()
|
|
{
|
|
/* wait for fault */
|
|
_faulter_tag = L4_Wait(&_last);
|
|
|
|
/*
|
|
* Read fault information
|
|
*/
|
|
|
|
/* exception */
|
|
if (exception()) {
|
|
L4_StoreMR(1, &_fault_ip);
|
|
|
|
if (verbose_exception)
|
|
error("exception (label ", Hex(L4_Label(_faulter_tag)), ") occured, "
|
|
"space=", Hex(L4_SenderSpace().raw), ", "
|
|
"ip=", Hex(_fault_ip));
|
|
}
|
|
|
|
/* page fault */
|
|
else {
|
|
L4_StoreMR(1, &_fault_addr);
|
|
L4_StoreMR(2, &_fault_ip);
|
|
|
|
if (verbose_page_fault)
|
|
print_page_fault(L4_Label(_faulter_tag), _fault_addr, _fault_ip, _last.raw);
|
|
}
|
|
_last_space = L4_SenderSpace().raw;
|
|
}
|
|
|
|
|
|
void Ipc_pager::reply_and_wait_for_fault()
|
|
{
|
|
L4_SpaceId_t to_space;
|
|
to_space.raw = L4_ThreadNo(_last) >> Thread_id_bits::THREAD;
|
|
|
|
/* map page to faulting space */
|
|
int ret = L4_MapFpage(to_space, _reply_mapping.fpage(),
|
|
_reply_mapping.phys_desc());
|
|
|
|
if (ret != 1)
|
|
error("L4_MapFpage returned ", ret, ", error=", L4_ErrorCode());
|
|
|
|
/* reply to page-fault message to resume the faulting thread */
|
|
acknowledge_wakeup();
|
|
|
|
wait_for_fault();
|
|
}
|
|
|
|
|
|
void Ipc_pager::acknowledge_wakeup()
|
|
{
|
|
/* answer wakeup call from one of core's region-manager sessions */
|
|
L4_LoadMR(0, 0);
|
|
L4_Send(_last);
|
|
}
|
|
|
|
|
|
/**********************
|
|
** Pager entrypoint **
|
|
**********************/
|
|
|
|
Untyped_capability Pager_entrypoint::_pager_object_cap(unsigned long badge)
|
|
{
|
|
return Capability_space::import(native_thread().l4id, Rpc_obj_key(badge));
|
|
}
|