mirror of
https://github.com/genodelabs/genode.git
synced 2024-12-26 00:41:08 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
80 lines
1.9 KiB
C++
80 lines
1.9 KiB
C++
/*
|
|
* \brief CPU state
|
|
* \author Sebastian Sumpf
|
|
* \date 2015-06-01
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2015-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _INCLUDE__RISCV__CPU__CPU_STATE_H_
|
|
#define _INCLUDE__RISCV__CPU__CPU_STATE_H_
|
|
|
|
/* Genode includes */
|
|
#include <base/stdint.h>
|
|
|
|
namespace Genode { struct Cpu_state; }
|
|
|
|
struct Genode::Cpu_state
|
|
{
|
|
enum Cpu_exception {
|
|
INSTRUCTION_UNALIGNED = 0,
|
|
INSTRUCTION_PAGE_FAULT = 1,
|
|
INSTRUCTION_ILLEGAL = 2,
|
|
BREAKPOINT = 3,
|
|
LOAD_UNALIGNED = 4,
|
|
LOAD_PAGE_FAULT = 5,
|
|
STORE_UNALIGNED = 6,
|
|
STORE_PAGE_FAULT = 7,
|
|
ECALL_FROM_USER = 8,
|
|
ECALL_FROM_SUPERVISOR = 9,
|
|
ECALL_FROM_HYPERVISOR = 10,
|
|
ECALL_FROM_MACHINE = 11,
|
|
RESET = 16,
|
|
IRQ_FLAG = 1UL << 63,
|
|
};
|
|
|
|
addr_t ip = 0;
|
|
addr_t cpu_exception = 0;
|
|
addr_t ra = 0;
|
|
addr_t sp = 0;
|
|
addr_t gp = 0;
|
|
addr_t tp = 0;
|
|
addr_t t0 = 0;
|
|
addr_t t1 = 0;
|
|
addr_t t2 = 0;
|
|
addr_t s0 = 0;
|
|
addr_t s1 = 0;
|
|
addr_t a0 = 0;
|
|
addr_t a1 = 0;
|
|
addr_t a2 = 0;
|
|
addr_t a3 = 0;
|
|
addr_t a4 = 0;
|
|
addr_t a5 = 0;
|
|
addr_t a6 = 0;
|
|
addr_t a7 = 0;
|
|
addr_t s2 = 0;
|
|
addr_t s3 = 0;
|
|
addr_t s4 = 0;
|
|
addr_t s5 = 0;
|
|
addr_t s6 = 0;
|
|
addr_t s7 = 0;
|
|
addr_t s8 = 0;
|
|
addr_t s9 = 0;
|
|
addr_t s10 = 0;
|
|
addr_t s11 = 0;
|
|
addr_t t3 = 0;
|
|
addr_t t4 = 0;
|
|
addr_t t5 = 0;
|
|
addr_t t6 = 0;
|
|
|
|
bool is_irq() { return cpu_exception & IRQ_FLAG; }
|
|
unsigned irq() { return cpu_exception ^ IRQ_FLAG; }
|
|
};
|
|
|
|
#endif /* _INCLUDE__RISCV__CPU__CPU_STATE_H_ */
|