mirror of
https://github.com/genodelabs/genode.git
synced 2024-12-23 15:32:25 +00:00
6d361b337b
This patch fixes an aliasing problem of the 'close' method signature that prevented the Input::Root_component::close method to be called. This way, the event-queue state was not reset at session-close time, which prevented a subsequent session-creation request to succeed. With the patch, input servers like ps2_drv, usb_drv that rely on the Input::Root_component support the dynamic re-opening of sessions. This happens in particular when using a dynamically configured input filter.
71 lines
1.7 KiB
C++
71 lines
1.7 KiB
C++
/*
|
|
* \brief Input root component
|
|
* \author Norman Feske
|
|
* \date 2014-05-31
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2014-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _INPUT__ROOT_H_
|
|
#define _INPUT__ROOT_H_
|
|
|
|
/* Genode includes */
|
|
#include <os/static_root.h>
|
|
#include <input/component.h>
|
|
|
|
namespace Input { class Root_component; }
|
|
|
|
|
|
/*
|
|
* This input root component tracks if the session has been opened. If a client
|
|
* is connected, the 'Event_queue::enabled' gets enabled. This is useful to
|
|
* omit the enqueuing of input events into the event queue before any client is
|
|
* interested in receiving input events. If we would not drop such early input
|
|
* events, the queue might overflow when input events are generated at boot
|
|
* times.
|
|
*/
|
|
class Input::Root_component : public Genode::Static_root<Input::Session>
|
|
{
|
|
private:
|
|
|
|
Genode::Rpc_entrypoint &_ep;
|
|
Input::Session_component &_session;
|
|
|
|
public:
|
|
|
|
Root_component(Genode::Rpc_entrypoint &ep, Input::Session_component &session)
|
|
:
|
|
Static_root<Input::Session>(ep.manage(&session)),
|
|
_ep(ep), _session(session)
|
|
{ }
|
|
|
|
~Root_component()
|
|
{
|
|
_ep.dissolve(&_session);
|
|
}
|
|
|
|
Genode::Capability<Genode::Session>
|
|
session(Genode::Root::Session_args const &args,
|
|
Genode::Affinity const &affinity) override
|
|
{
|
|
if (_session.event_queue().enabled())
|
|
throw Genode::Service_denied();
|
|
|
|
_session.event_queue().enabled(true);
|
|
|
|
return Static_root<Input::Session>::session(args, affinity);
|
|
}
|
|
|
|
void close(Genode::Capability<Genode::Session>) override
|
|
{
|
|
_session.event_queue().enabled(false);
|
|
}
|
|
};
|
|
|
|
#endif /* _INPUT__ROOT_H_ */
|