Norman Feske eba9c15746 Follow practices suggested by "Effective C++" ... The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465		2018-01-17 12:14:35 +01:00
..
doc	sel4: 3rd article - porting core to seL4	2015-05-26 09:40:02 +02:00
etc	sel4: add Wandboard Quad (iMX6) support	2017-08-17 11:04:21 +02:00
include/sel4	Adjust file headers to refer to the AGPLv3	2017-02-28 12:59:29 +01:00
lib	core: add support to export log output as ROM	2017-12-21 15:01:46 +01:00
mk/spec	Disambiguate kernel-specific file names	2016-12-23 16:51:32 +01:00
patches	sel4: use kernel branch 7.0 + our mastered commits	2017-12-21 15:01:45 +01:00
ports	sel4: use kernel branch 7.0 + our mastered commits	2017-12-21 15:01:45 +01:00
recipes/src/base-sel4	depot: update recipe hashes	2017-12-21 15:01:56 +01:00
src	Follow practices suggested by "Effective C++"	2018-01-17 12:14:35 +01:00