mirror of
https://github.com/genodelabs/genode.git
synced 2024-12-24 07:46:42 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465
172 lines
3.9 KiB
C++
172 lines
3.9 KiB
C++
/*
|
|
* \brief Utility for in-place (re-)construction of objects
|
|
* \author Norman Feske
|
|
* \date 2014-01-10
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2014-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _INCLUDE__UTIL__RECONSTRUCTIBLE_H_
|
|
#define _INCLUDE__UTIL__RECONSTRUCTIBLE_H_
|
|
|
|
#include <util/construct_at.h>
|
|
#include <base/stdint.h>
|
|
#include <util/noncopyable.h>
|
|
|
|
namespace Genode {
|
|
template<typename> class Reconstructible;
|
|
template<typename> class Constructible;
|
|
}
|
|
|
|
|
|
/**
|
|
* Place holder for an object to be repeatedly constructed and destructed
|
|
*
|
|
* This class template acts as a smart pointer that refers to an object
|
|
* contained within the smart pointer itself. The contained object may be
|
|
* repeatedly constructed and destructed while staying in the same place. This
|
|
* is useful for replacing aggregated members during the lifetime of a compound
|
|
* object.
|
|
*
|
|
* \param MT type
|
|
*/
|
|
template <typename MT>
|
|
class Genode::Reconstructible : Noncopyable
|
|
{
|
|
private:
|
|
|
|
/**
|
|
* Static reservation of memory for the embedded object
|
|
*/
|
|
char _space[sizeof(MT)] __attribute__((aligned(sizeof(addr_t))));
|
|
|
|
/**
|
|
* True if the volatile object contains a constructed object
|
|
*/
|
|
bool _constructed = false;
|
|
|
|
template <typename... ARGS> void _do_construct(ARGS &&... args)
|
|
{
|
|
construct_at<MT>(_space, args...);
|
|
_constructed = true;
|
|
}
|
|
|
|
MT *_ptr() { return reinterpret_cast<MT *>(_space); }
|
|
MT const *_const_ptr() const { return reinterpret_cast<MT const *>(_space); }
|
|
|
|
void _check_constructed() const
|
|
{
|
|
if (!_constructed)
|
|
throw Deref_unconstructed_object();
|
|
}
|
|
|
|
protected:
|
|
|
|
/**
|
|
* Dummy type used as a hook for 'Constructible' to bypass the
|
|
* default constructor by invoking the 'Reconstructible(Lazy *)'
|
|
* constructor.
|
|
*/
|
|
struct Lazy { };
|
|
|
|
/**
|
|
* Constructor that omits the initial construction of the object
|
|
*/
|
|
Reconstructible(Lazy *) { }
|
|
|
|
public:
|
|
|
|
class Deref_unconstructed_object { };
|
|
|
|
/**
|
|
* Constructor
|
|
*
|
|
* The arguments are forwarded to the constructor of the embedded
|
|
* object.
|
|
*/
|
|
template <typename... ARGS>
|
|
Reconstructible(ARGS &&... args)
|
|
{
|
|
_do_construct(args...);
|
|
}
|
|
|
|
~Reconstructible() { destruct(); }
|
|
|
|
/**
|
|
* Construct new object in place
|
|
*
|
|
* If the 'Reconstructible' already hosts a constructed object, the old
|
|
* object will be destructed first.
|
|
*/
|
|
template <typename... ARGS>
|
|
void construct(ARGS &&... args)
|
|
{
|
|
destruct();
|
|
_do_construct(args...);
|
|
}
|
|
|
|
/**
|
|
* Destruct object
|
|
*/
|
|
void destruct()
|
|
{
|
|
if (!_constructed)
|
|
return;
|
|
|
|
/* invoke destructor */
|
|
_ptr()->~MT();
|
|
|
|
_constructed = false;
|
|
}
|
|
|
|
/**
|
|
* Return true of volatile object contains a constructed object
|
|
*/
|
|
bool constructed() const { return _constructed; }
|
|
|
|
/**
|
|
* Return true of volatile object contains a constructed object
|
|
*
|
|
* \deprecated use 'constructed' instead
|
|
*/
|
|
bool is_constructed() const { return constructed(); }
|
|
|
|
/**
|
|
* Access contained object
|
|
*/
|
|
MT *operator -> () { _check_constructed(); return _ptr(); }
|
|
MT const *operator -> () const { _check_constructed(); return _const_ptr(); }
|
|
|
|
MT &operator * () { _check_constructed(); return *_ptr(); }
|
|
MT const &operator * () const { _check_constructed(); return *_const_ptr(); }
|
|
|
|
void print(Output &out) const
|
|
{
|
|
if (_constructed)
|
|
_const_ptr()->print(out);
|
|
else
|
|
out.out_string("<unconstructed>");
|
|
}
|
|
};
|
|
|
|
|
|
/**
|
|
* Reconstructible object that holds no initially constructed object
|
|
*/
|
|
template <typename MT>
|
|
struct Genode::Constructible : Reconstructible<MT>
|
|
{
|
|
template <typename... ARGS>
|
|
Constructible(ARGS &&...)
|
|
:
|
|
Reconstructible<MT>((typename Reconstructible<MT>::Lazy *)nullptr)
|
|
{ }
|
|
};
|
|
|
|
#endif /* _INCLUDE__UTIL__RECONSTRUCTIBLE_H_ */
|