mirror of
https://github.com/genodelabs/genode.git
synced 2024-12-28 17:48:53 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
126 lines
2.7 KiB
C++
126 lines
2.7 KiB
C++
/*
|
|
* \brief GPIO driver interface
|
|
* \author Stefan Kalkowski
|
|
* \date 2013-05-03
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2011-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _INCLUDE__GPIO__DRIVER_H_
|
|
#define _INCLUDE__GPIO__DRIVER_H_
|
|
|
|
/* Genode includes */
|
|
#include <base/signal.h>
|
|
|
|
namespace Gpio { struct Driver; }
|
|
|
|
|
|
struct Gpio::Driver : Genode::Interface
|
|
{
|
|
/**
|
|
* Set direction of GPIO pin, whether it's an input or output one
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void direction(unsigned gpio, bool input) = 0;
|
|
|
|
/**
|
|
* Set output level (high or low)
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void write(unsigned gpio, bool enable) = 0;
|
|
|
|
/**
|
|
* Read input level (high or low)
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual bool read(unsigned gpio) = 0;
|
|
|
|
/**
|
|
* Enable/disable debounce logic for the GPIO pin
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void debounce_enable(unsigned gpio, bool enable) = 0;
|
|
|
|
/**
|
|
* Set delay for debounce logic for the GPIO pin
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void debounce_time(unsigned gpio, unsigned long us) = 0;
|
|
|
|
/**
|
|
* Set IRQ trigger state to falling edge-triggered
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void falling_detect(unsigned gpio) = 0;
|
|
|
|
/**
|
|
* Set IRQ trigger state to rising edge-triggered
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void rising_detect(unsigned gpio) = 0;
|
|
|
|
/**
|
|
* Set IRQ trigger state to high level-triggered
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void high_detect(unsigned gpio) = 0;
|
|
|
|
/**
|
|
* Set IRQ trigger state to low level-triggered
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void low_detect(unsigned gpio) = 0;
|
|
|
|
/**
|
|
* Enable/disable IRQ for specified GPIO pin
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void irq_enable(unsigned gpio, bool enable) = 0;
|
|
|
|
/**
|
|
* Acknowledge IRQ for specified GPIO pin
|
|
*
|
|
* \param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void ack_irq(unsigned gpio) = 0;
|
|
|
|
/**
|
|
* Register signal handler for interrupts
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void register_signal(unsigned gpio,
|
|
Genode::Signal_context_capability cap) = 0;
|
|
|
|
/**
|
|
* Unregister signal handler
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual void unregister_signal(unsigned gpio) = 0;
|
|
|
|
/**
|
|
* Check whether GPIO number is valid
|
|
*
|
|
*\param gpio corresponding gpio pin number
|
|
*/
|
|
virtual bool gpio_valid(unsigned gpio) = 0;
|
|
};
|
|
|
|
#endif /* _INCLUDE__GPIO__DRIVER_H_ */
|