mirror of
https://github.com/genodelabs/genode.git
synced 2024-12-26 17:01:07 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
122 lines
2.8 KiB
C++
122 lines
2.8 KiB
C++
/*
|
|
* \brief Client-side TRACE session interface
|
|
* \author Norman Feske
|
|
* \date 2013-08-12
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2013-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _INCLUDE__TRACE_SESSION__CLIENT_H_
|
|
#define _INCLUDE__TRACE_SESSION__CLIENT_H_
|
|
|
|
#include <trace_session/trace_session.h>
|
|
#include <base/rpc_client.h>
|
|
#include <base/env.h>
|
|
|
|
namespace Genode { namespace Trace { struct Session_client; } }
|
|
|
|
|
|
struct Genode::Trace::Session_client : Genode::Rpc_client<Genode::Trace::Session>
|
|
{
|
|
private:
|
|
|
|
/**
|
|
* Shared-memory buffer used for carrying the payload of the
|
|
* 'subjects()' RPC function.
|
|
*/
|
|
class Argument_buffer
|
|
{
|
|
private:
|
|
|
|
/*
|
|
* Noncopyable
|
|
*/
|
|
Argument_buffer(Argument_buffer const &);
|
|
Argument_buffer &operator = (Argument_buffer const &);
|
|
|
|
public:
|
|
|
|
Region_map &rm;
|
|
char *base;
|
|
size_t size;
|
|
|
|
Argument_buffer(Region_map &rm, Dataspace_capability ds)
|
|
:
|
|
rm(rm),
|
|
base(rm.attach(ds)),
|
|
size(ds.call<Dataspace::Rpc_size>())
|
|
{ }
|
|
|
|
~Argument_buffer()
|
|
{
|
|
rm.detach(base);
|
|
}
|
|
};
|
|
|
|
Argument_buffer _argument_buffer;
|
|
|
|
public:
|
|
|
|
/**
|
|
* Constructor
|
|
*/
|
|
explicit Session_client(Region_map &rm, Capability<Trace::Session> session)
|
|
:
|
|
Rpc_client<Trace::Session>(session),
|
|
_argument_buffer(rm, call<Rpc_dataspace>())
|
|
{ }
|
|
|
|
/**
|
|
* Retrieve subject directory
|
|
*
|
|
* \throw Out_of_ram
|
|
* \throw Out_of_caps
|
|
*/
|
|
size_t subjects(Subject_id *dst, size_t dst_len)
|
|
{
|
|
size_t const num_subjects = min(call<Rpc_subjects>(), dst_len);
|
|
|
|
memcpy(dst, _argument_buffer.base, dst_len*sizeof(Subject_id));
|
|
|
|
return num_subjects;
|
|
}
|
|
|
|
Policy_id alloc_policy(size_t size) override {
|
|
return call<Rpc_alloc_policy>(size); }
|
|
|
|
Dataspace_capability policy(Policy_id policy_id) override {
|
|
return call<Rpc_policy>(policy_id); }
|
|
|
|
void unload_policy(Policy_id policy_id) override {
|
|
call<Rpc_unload_policy>(policy_id); }
|
|
|
|
void trace(Subject_id s, Policy_id p, size_t buffer_size) override {
|
|
call<Rpc_trace>(s, p, buffer_size); }
|
|
|
|
void rule(Session_label const &label, Thread_name const &thread,
|
|
Policy_id policy, size_t buffer_size) override {
|
|
call<Rpc_rule>(label, thread, policy, buffer_size); }
|
|
|
|
void pause(Subject_id subject) override {
|
|
call<Rpc_pause>(subject); }
|
|
|
|
void resume(Subject_id subject) override {
|
|
call<Rpc_resume>(subject); }
|
|
|
|
Subject_info subject_info(Subject_id subject) override {
|
|
return call<Rpc_subject_info>(subject); }
|
|
|
|
Dataspace_capability buffer(Subject_id subject) override {
|
|
return call<Rpc_buffer>(subject); }
|
|
|
|
void free(Subject_id subject) override {
|
|
call<Rpc_free>(subject); }
|
|
};
|
|
|
|
#endif /* _INCLUDE__TRACE_SESSION__CLIENT_H_ */
|