mirror of
https://github.com/genodelabs/genode.git
synced 2025-05-04 01:33:02 +00:00
6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
31 lines
709 B
C++
31 lines
709 B
C++
/*
|
|
* \brief Mapping of Genode's capability names to kernel capabilities.
|
|
* \author Stefan Kalkowski
|
|
* \date 2010-12-06
|
|
*
|
|
* This is a Fiasco.OC-specific addition to the process enviroment.
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2010-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#include <base/internal/cap_map.h>
|
|
|
|
void Genode::Capability_map::remove(Genode::Cap_index* i)
|
|
{
|
|
using namespace Genode;
|
|
|
|
Lock_guard<Spin_lock> guard(_lock);
|
|
|
|
if (i) {
|
|
Cap_index *e = _tree.first() ? _tree.first()->find_by_id(i->id()) : 0;
|
|
if (e == i)
|
|
_tree.remove(i);
|
|
cap_idx_alloc().free(i, 1);
|
|
}
|
|
}
|