mirror of
https://github.com/genodelabs/genode.git
synced 2024-12-29 10:08:53 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465
176 lines
4.2 KiB
C++
176 lines
4.2 KiB
C++
/*
|
|
* \brief Nitpicker-based graphics backend for scout
|
|
* \date 2013-12-30
|
|
* \author Norman Feske
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2013-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _INCLUDE__SCOUT__NITPICKER_GRAPHICS_BACKEND_H_
|
|
#define _INCLUDE__SCOUT__NITPICKER_GRAPHICS_BACKEND_H_
|
|
|
|
/* Genode includes */
|
|
#include <nitpicker_session/connection.h>
|
|
#include <os/pixel_rgb565.h>
|
|
#include <base/attached_dataspace.h>
|
|
|
|
/* Scout includes */
|
|
#include <scout/graphics_backend.h>
|
|
|
|
|
|
namespace Scout {
|
|
using Genode::Pixel_rgb565;
|
|
class Nitpicker_graphics_backend;
|
|
}
|
|
|
|
|
|
class Scout::Nitpicker_graphics_backend : public Graphics_backend
|
|
{
|
|
private:
|
|
|
|
/*
|
|
* Noncopyable
|
|
*/
|
|
Nitpicker_graphics_backend(Nitpicker_graphics_backend const &);
|
|
Nitpicker_graphics_backend &operator = (Nitpicker_graphics_backend const &);
|
|
|
|
Genode::Region_map &_local_rm;
|
|
|
|
Nitpicker::Connection &_nitpicker;
|
|
|
|
Genode::Dataspace_capability _init_fb_ds(Area max_size)
|
|
{
|
|
_nitpicker.buffer(Framebuffer::Mode(max_size.w(), max_size.h()*2,
|
|
Framebuffer::Mode::RGB565), false);
|
|
return _nitpicker.framebuffer()->dataspace();
|
|
}
|
|
|
|
Area _max_size;
|
|
|
|
Genode::Attached_dataspace _fb_ds { _local_rm, _init_fb_ds(_max_size) };
|
|
|
|
typedef Nitpicker::Session::View_handle View_handle;
|
|
|
|
Point _position;
|
|
Area _view_size;
|
|
View_handle _view { _nitpicker.create_view() };
|
|
Canvas_base *_canvas[2];
|
|
bool _flip_state = { false };
|
|
|
|
void _update_viewport()
|
|
{
|
|
typedef Nitpicker::Session::Command Command;
|
|
|
|
Nitpicker::Rect rect(_position, _view_size);
|
|
_nitpicker.enqueue<Command::Geometry>(_view, rect);
|
|
|
|
Nitpicker::Point offset(0, _flip_state ? -_max_size.h() : 0);
|
|
_nitpicker.enqueue<Command::Offset>(_view, offset);
|
|
|
|
_nitpicker.execute();
|
|
}
|
|
|
|
void _refresh_view(Rect rect)
|
|
{
|
|
int const y_offset = _flip_state ? _max_size.h() : 0;
|
|
_nitpicker.framebuffer()->refresh(rect.x1(), rect.y1() + y_offset,
|
|
rect.w(), rect.h());
|
|
}
|
|
|
|
template <typename PT>
|
|
PT *_base(unsigned idx)
|
|
{
|
|
return (PT *)_fb_ds.local_addr<PT>() + idx*_max_size.count();
|
|
}
|
|
|
|
unsigned _front_idx() const { return _flip_state ? 1 : 0; }
|
|
unsigned _back_idx() const { return _flip_state ? 0 : 1; }
|
|
|
|
public:
|
|
|
|
/**
|
|
* Constructor
|
|
*
|
|
* \param alloc allocator used for allocating textures
|
|
*/
|
|
Nitpicker_graphics_backend(Genode::Region_map &local_rm,
|
|
Nitpicker::Connection &nitpicker,
|
|
Genode::Allocator &alloc,
|
|
Area max_size, Point position, Area view_size)
|
|
:
|
|
_local_rm(local_rm),
|
|
_nitpicker(nitpicker),
|
|
_max_size(max_size),
|
|
_position(position),
|
|
_view_size(view_size)
|
|
{
|
|
bring_to_front();
|
|
|
|
typedef Genode::Pixel_rgb565 PT;
|
|
static Canvas<PT> canvas_0(_base<PT>(0), max_size, alloc);
|
|
static Canvas<PT> canvas_1(_base<PT>(1), max_size, alloc);
|
|
|
|
_canvas[0] = &canvas_0;
|
|
_canvas[1] = &canvas_1;
|
|
}
|
|
|
|
|
|
/********************************
|
|
** Graphics_backend interface **
|
|
********************************/
|
|
|
|
Canvas_base &front() override { return *_canvas[_front_idx()]; }
|
|
Canvas_base &back() override { return *_canvas[ _back_idx()]; }
|
|
|
|
void copy_back_to_front(Rect rect)
|
|
{
|
|
|
|
typedef Genode::Pixel_rgb565 PT;
|
|
|
|
PT const *src = _base<PT>( _back_idx());
|
|
PT *dst = _base<PT>(_front_idx());
|
|
|
|
unsigned long const offset = rect.y1()*_max_size.w() + rect.x1();
|
|
|
|
src += offset;
|
|
dst += offset;
|
|
|
|
blit(src, sizeof(PT)*_max_size.w(),
|
|
dst, sizeof(PT)*_max_size.w(), sizeof(PT)*rect.w(), rect.h());
|
|
|
|
_refresh_view(rect);
|
|
}
|
|
|
|
void swap_back_and_front()
|
|
{
|
|
_flip_state = !_flip_state;
|
|
_update_viewport();
|
|
}
|
|
|
|
void position(Point p)
|
|
{
|
|
_position = p;
|
|
_update_viewport();
|
|
}
|
|
|
|
void bring_to_front()
|
|
{
|
|
typedef Nitpicker::Session::Command Command;
|
|
typedef Nitpicker::Session::View_handle View_handle;
|
|
_nitpicker.enqueue<Command::To_front>(_view, View_handle());
|
|
_nitpicker.execute();
|
|
}
|
|
|
|
void view_area(Area area)
|
|
{
|
|
_view_size = area;
|
|
}
|
|
};
|
|
|
|
#endif /* _INCLUDE__SCOUT__NITPICKER_GRAPHICS_BACKEND_H_ */
|