mirror of
https://github.com/genodelabs/genode.git
synced 2025-01-25 13:49:48 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
146 lines
3.2 KiB
C++
146 lines
3.2 KiB
C++
/*
|
|
* \brief Ethernet protocol
|
|
* \author Stefan Kalkowski
|
|
* \date 2010-08-19
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2010-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _NET__ETHERNET_H_
|
|
#define _NET__ETHERNET_H_
|
|
|
|
/* Genode includes */
|
|
#include <base/exception.h>
|
|
#include <util/string.h>
|
|
|
|
#include <util/endian.h>
|
|
#include <net/mac_address.h>
|
|
|
|
namespace Net
|
|
{
|
|
class Ethernet_frame;
|
|
|
|
template <Genode::size_t DATA_SIZE>
|
|
class Ethernet_frame_sized;
|
|
}
|
|
|
|
|
|
/**
|
|
* Data layout of this class conforms to the Ethernet II frame
|
|
* (IEEE 802.3).
|
|
*
|
|
* Ethernet-frame-header-format:
|
|
*
|
|
* ----------------------------------------------------------
|
|
* | destination mac address | source mac address | ethertype |
|
|
* | 6 bytes | 6 bytes | 2 bytes |
|
|
* ----------------------------------------------------------
|
|
*/
|
|
class Net::Ethernet_frame
|
|
{
|
|
public:
|
|
|
|
enum Size {
|
|
ADDR_LEN = 6, /* MAC address length in bytes */
|
|
};
|
|
|
|
|
|
static const Mac_address BROADCAST; /* broadcast address */
|
|
|
|
private:
|
|
|
|
Genode::uint8_t _dst[ADDR_LEN]; /* destination mac address */
|
|
Genode::uint8_t _src[ADDR_LEN]; /* source mac address */
|
|
Genode::uint16_t _type; /* encapsulated protocol */
|
|
unsigned _data[0]; /* encapsulated data */
|
|
|
|
public:
|
|
|
|
class No_ethernet_frame : Genode::Exception {};
|
|
|
|
enum { MIN_SIZE = 64 };
|
|
|
|
/**
|
|
* Id representing encapsulated protocol.
|
|
*/
|
|
enum class Type : Genode::uint16_t {
|
|
IPV4 = 0x0800,
|
|
ARP = 0x0806,
|
|
};
|
|
|
|
static void validate_size(Genode::size_t size)
|
|
{
|
|
/* at least, frame header needs to fit in */
|
|
if (size < sizeof(Ethernet_frame))
|
|
throw No_ethernet_frame();
|
|
}
|
|
|
|
|
|
/***************
|
|
** Accessors **
|
|
***************/
|
|
|
|
Mac_address dst() const { return Mac_address((void *)_dst); }
|
|
Mac_address src() const { return Mac_address((void *)_src); }
|
|
Type type() const { return (Type)host_to_big_endian(_type); }
|
|
template <typename T> T const *data() const { return (T const *)(_data); }
|
|
template <typename T> T *data() { return (T *)(_data); }
|
|
|
|
void dst(Mac_address v) { v.copy(&_dst); }
|
|
void src(Mac_address v) { v.copy(&_src); }
|
|
void type(Type type) { _type = host_to_big_endian((Genode::uint16_t)type); }
|
|
|
|
|
|
/***************
|
|
** Operators **
|
|
***************/
|
|
|
|
/**
|
|
* Placement new operator.
|
|
*/
|
|
void * operator new(__SIZE_TYPE__, void* addr) { return addr; }
|
|
|
|
|
|
/*********
|
|
** log **
|
|
*********/
|
|
|
|
void print(Genode::Output &output) const;
|
|
|
|
} __attribute__((packed));
|
|
|
|
|
|
template <Genode::size_t DATA_SIZE>
|
|
class Net::Ethernet_frame_sized : public Ethernet_frame
|
|
{
|
|
private:
|
|
|
|
enum {
|
|
HS = sizeof(Ethernet_frame),
|
|
DS = DATA_SIZE + HS >= MIN_SIZE ? DATA_SIZE : MIN_SIZE - HS,
|
|
};
|
|
|
|
Genode::uint8_t _data[DS];
|
|
Genode::uint32_t _checksum;
|
|
|
|
public:
|
|
|
|
Ethernet_frame_sized(Mac_address dst_in, Mac_address src_in,
|
|
Type type_in)
|
|
:
|
|
Ethernet_frame(sizeof(Ethernet_frame))
|
|
{
|
|
dst(dst_in);
|
|
src(src_in);
|
|
type(type_in);
|
|
}
|
|
|
|
} __attribute__((packed));
|
|
|
|
#endif /* _NET__ETHERNET_H_ */
|