mirror of
https://github.com/genodelabs/genode.git
synced 2025-05-05 10:13:15 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
120 lines
2.8 KiB
C++
120 lines
2.8 KiB
C++
/*
|
|
* \brief Utility to attach a dataspace to the local address space
|
|
* \author Norman Feske
|
|
* \date 2014-01-10
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2014-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _INCLUDE__BASE__ATTACHED_DATASPACE_H_
|
|
#define _INCLUDE__BASE__ATTACHED_DATASPACE_H_
|
|
|
|
#include <dataspace/client.h>
|
|
#include <base/env.h>
|
|
|
|
namespace Genode { class Attached_dataspace; }
|
|
|
|
|
|
class Genode::Attached_dataspace : Noncopyable
|
|
{
|
|
public:
|
|
|
|
typedef Region_map::Invalid_dataspace Invalid_dataspace;
|
|
|
|
private:
|
|
|
|
Dataspace_capability _ds;
|
|
|
|
Region_map &_rm;
|
|
|
|
size_t const _size = { Dataspace_client(_ds).size() };
|
|
|
|
void * _local_addr = nullptr;
|
|
|
|
Dataspace_capability _check(Dataspace_capability ds)
|
|
{
|
|
if (ds.valid())
|
|
return ds;
|
|
|
|
throw Region_map::Invalid_dataspace();
|
|
}
|
|
|
|
/*
|
|
* Noncopyable
|
|
*/
|
|
Attached_dataspace(Attached_dataspace const &);
|
|
Attached_dataspace &operator = (Attached_dataspace const &);
|
|
|
|
public:
|
|
|
|
/**
|
|
* Constructor
|
|
*
|
|
* \throw Region_map::Region_conflict
|
|
* \throw Region_map::Invalid_dataspace
|
|
* \throw Out_of_caps
|
|
* \throw Out_of_ram
|
|
*/
|
|
Attached_dataspace(Region_map &rm, Dataspace_capability ds)
|
|
: _ds(_check(ds)), _rm(rm), _local_addr(_rm.attach(_ds)) { }
|
|
|
|
/**
|
|
* Constructor
|
|
*
|
|
* \noapi
|
|
* \deprecated Use the constructor with 'Region_map &' as first
|
|
* argument instead
|
|
*/
|
|
Attached_dataspace(Dataspace_capability ds) __attribute__((deprecated))
|
|
: _ds(_check(ds)), _rm(*env_deprecated()->rm_session()), _local_addr(_rm.attach(_ds)) { }
|
|
|
|
/**
|
|
* Destructor
|
|
*/
|
|
~Attached_dataspace()
|
|
{
|
|
if (_local_addr)
|
|
_rm.detach(_local_addr);
|
|
}
|
|
|
|
/**
|
|
* Return capability of the used dataspace
|
|
*/
|
|
Dataspace_capability cap() const { return _ds; }
|
|
|
|
/**
|
|
* Request local address
|
|
*
|
|
* This is a template to avoid inconvenient casts at the caller.
|
|
* A newly attached dataspace is untyped memory anyway.
|
|
*/
|
|
template <typename T>
|
|
T *local_addr() { return static_cast<T *>(_local_addr); }
|
|
|
|
template <typename T>
|
|
T const *local_addr() const { return static_cast<T const *>(_local_addr); }
|
|
|
|
/**
|
|
* Return size
|
|
*/
|
|
size_t size() const { return _size; }
|
|
|
|
/**
|
|
* Forget dataspace, thereby skipping the detachment on destruction
|
|
*
|
|
* This method can be called if the the dataspace is known to be
|
|
* physically destroyed, e.g., because the session where the dataspace
|
|
* originated from was closed. In this case, core will already have
|
|
* removed the memory mappings of the dataspace. So we have to omit the
|
|
* detach operation in '~Attached_dataspace'.
|
|
*/
|
|
void invalidate() { _local_addr = nullptr; }
|
|
};
|
|
|
|
#endif /* _INCLUDE__BASE__ATTACHED_DATASPACE_H_ */
|