ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-23 23:42:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

nic_dump: Remove unused Net::Interface::_alloc

Browse Source 
This private member variable is not used anywhere in the code. This
breaks builds using clang instead of GCC. Drop the variable.

Issue #3984
This commit is contained in:
Piotr Tworek 2021-01-11 00:05:48 +01:00 committed by Norman Feske
parent 428de89f9a
commit fc089a1673
4 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
repos/os/src/server/nic_dump/component.cc
View File

@ -73,8 +73,7 @@ Net::Session_component::Session_component(Ram_quota const ram_quota,
Session_rpc_object(env.rm(), _tx_buf, _rx_buf, &_range_alloc, Session_rpc_object(env.rm(), _tx_buf, _rx_buf, &_range_alloc,
env.ep().rpc_ep()), env.ep().rpc_ep()),
Interface(env.ep(), config.attribute_value("downlink", Interface_label()), Interface(env.ep(), config.attribute_value("downlink", Interface_label()),
timer, curr_time, config.attribute_value("time", false), timer, curr_time, config.attribute_value("time", false), config),
Session_component_base::_alloc, config),
_uplink(env, config, timer, curr_time, Session_component_base::_alloc), _uplink(env, config, timer, curr_time, Session_component_base::_alloc),
_link_state_handler(env.ep(), *this, &Session_component::_handle_link_state) _link_state_handler(env.ep(), *this, &Session_component::_handle_link_state)
{ {

2
repos/os/src/server/nic_dump/interface.cc
View File

@ -96,14 +96,12 @@ Net::Interface::Interface(Entrypoint &ep,
Timer::Connection &timer, Timer::Connection &timer,
Duration &curr_time, Duration &curr_time,
bool log_time, bool log_time,
Allocator &alloc,
Xml_node config) Xml_node config)
: :
_sink_ack { ep, *this, &Interface::_ack_avail }, _sink_ack { ep, *this, &Interface::_ack_avail },
_sink_submit { ep, *this, &Interface::_ready_to_submit }, _sink_submit { ep, *this, &Interface::_ready_to_submit },
_source_ack { ep, *this, &Interface::_ready_to_ack }, _source_ack { ep, *this, &Interface::_ready_to_ack },
_source_submit { ep, *this, &Interface::_packet_avail }, _source_submit { ep, *this, &Interface::_packet_avail },
_alloc { alloc },
_label { label }, _label { label },
_timer { timer }, _timer { timer },
_curr_time { curr_time }, _curr_time { curr_time },

2
repos/os/src/server/nic_dump/interface.h
View File

@ -49,7 +49,6 @@ class Net::Interface
private: private:
Genode::Allocator &_alloc;
Pointer<Interface> _remote { }; Pointer<Interface> _remote { };
Interface_label _label; Interface_label _label;
Timer::Connection &_timer; Timer::Connection &_timer;
@ -85,7 +84,6 @@ class Net::Interface
Timer::Connection &timer, Timer::Connection &timer,
Genode::Duration &curr_time, Genode::Duration &curr_time,
bool log_time, bool log_time,
Genode::Allocator &alloc,
Genode::Xml_node config); Genode::Xml_node config);
virtual ~Interface() { } virtual ~Interface() { }

2
repos/os/src/server/nic_dump/uplink.cc
View File

@ -32,7 +32,7 @@ Net::Uplink::Uplink(Env &env,
Nic::Connection { env, this, BUF_SIZE, BUF_SIZE }, Nic::Connection { env, this, BUF_SIZE, BUF_SIZE },
Net::Interface { env.ep(), config.attribute_value("uplink", Interface_label()), Net::Interface { env.ep(), config.attribute_value("uplink", Interface_label()),
timer, curr_time, config.attribute_value("time", false), timer, curr_time, config.attribute_value("time", false),
alloc, config } config }
{ {
rx_channel()->sigh_ready_to_ack(_sink_ack); rx_channel()->sigh_ready_to_ack(_sink_ack);
rx_channel()->sigh_packet_avail(_sink_submit); rx_channel()->sigh_packet_avail(_sink_submit);