ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-18 23:28:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

gui_session: manage view ID at the client side

Browse Source 
This patch moves the management of view IDs from the server to the
client side. The former 'create_view' and 'create_child_view'
operations do no longer return a view ID but take a view ID as
argument. While changing those operations, this patch takes the
opportunity to allow for initial view attributes. Combined, those
changes simplify the window manager while accommodating typical
client use cases with less code.

To ease the client-side ID management, the Gui::Connection hosts
a 'view_ids' ID space for optional use. E.g., the new 'Top_level_view'
class uses this ID space for ID allocation. This class accommodates the
most typical use case of opening a single window.

The 'alloc_view_id' RPC function is no longer needed.

Issue #5242
This commit is contained in:
Norman Feske
2024-08-09 14:27:26 +02:00
committed by Christian Helmuth
parent 805e3552fd
commit f98c356efd
37 changed files with 583 additions and 944 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
repos/demo/src/server/nitlog/main.cc
View File

@ -348,48 +348,6 @@ class Nitlog::Root : public Root_component<Session_component>
};
class Log_view
{
private:
Gui::Connection &_gui;
Gui::Point _pos;
Gui::Area _size;
Gui::View_id const _view = _gui.create_view();
using Command = Gui::Session::Command;
public:
Log_view(Gui::Connection &gui, Gui::Rect geometry)
:
_gui(gui),
_pos(geometry.at),
_size(geometry.area)
{
move(_pos);
top();
}
void top()
{
_gui.enqueue<Command::Front>(_view);
_gui.execute();
}
void move(Gui::Point pos)
{
_pos = pos;
Gui::Rect rect(_pos, _size);
_gui.enqueue<Command::Geometry>(_view, rect);
_gui.execute();
}
Gui::Point pos() const { return _pos; }
};
struct Nitlog::Main
{
Env &_env;
@ -435,10 +393,7 @@ struct Nitlog::Main
bool const _canvas_initialized = (_init_canvas(), true);
/* create view for log window */
Gui::Rect const _view_geometry { Gui::Point(20, 20),
Gui::Area(_win_w, _win_h) };
Log_view _view { _gui, _view_geometry };
Gui::Top_level_view _view { _gui, { { 20, 20 }, { _win_w, _win_h } } };
/* create root interface for service */
Root _root { _env.ep(), _sliced_heap, _log_window };
@ -471,14 +426,14 @@ struct Nitlog::Main
Gui::Point const mouse_pos(x, y);
if (_key_cnt && _old_mouse_pos != _initial_mouse_pos)
_view.move(_view.pos() + mouse_pos - _old_mouse_pos);
_view.at(_view.at() + mouse_pos - _old_mouse_pos);
_old_mouse_pos = mouse_pos;
});
/* find selected view and bring it to front */
if (ev.press() && _key_cnt == 1)
_view.top();
_view.front();
}
}